Add Audio support for BPM ICON1.PAM - #19336
Merged
Merged
Conversation
Megamouse
reviewed
Aug 27, 2026
Megamouse
enabled auto-merge (squash)
August 29, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in the Big Picture Mode when selecting a game to look at its details, the ICON1.PAM video would start to play but there would be no audio playing if the .PAM file had it. This PR fixes that.
Note: the change in qt_video_source.cpp is needed because it seemed like it didn't use it's own parameter. Without that, the audio would not fade out even after you left the game details.