From 57057ddea89c0090243b401b91c3e48a9296d325 Mon Sep 17 00:00:00 2001 From: kd-11 Date: Fri, 28 Aug 2026 17:45:24 +0300 Subject: [PATCH] rsx/qt: Move blit engine upscaling option to debug settings --- rpcs3/Emu/RSX/Common/texture_cache.h | 2 +- rpcs3/Emu/system_config.h | 2 +- rpcs3/rpcs3qt/emu_settings_type.cpp | 2 +- rpcs3/rpcs3qt/emu_settings_type.h | 2 +- rpcs3/rpcs3qt/settings_dialog.cpp | 2 +- rpcs3/rpcs3qt/settings_dialog.ui | 14 +++++++------- rpcs3/rpcs3qt/tooltips.h | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/rpcs3/Emu/RSX/Common/texture_cache.h b/rpcs3/Emu/RSX/Common/texture_cache.h index fc0824c77077..e0d9446dc3e4 100644 --- a/rpcs3/Emu/RSX/Common/texture_cache.h +++ b/rpcs3/Emu/RSX/Common/texture_cache.h @@ -1784,7 +1784,7 @@ namespace rsx }; surface_scaling_config_t scaling_config{}; - if (g_cfg.video.allow_blit_engine_upscaling) + if (!g_cfg.video.disable_blit_engine_upscaling) { scaling_config = { diff --git a/rpcs3/Emu/system_config.h b/rpcs3/Emu/system_config.h index 93eadc5cf68d..2ada1a84ee45 100644 --- a/rpcs3/Emu/system_config.h +++ b/rpcs3/Emu/system_config.h @@ -180,7 +180,7 @@ struct cfg_root : cfg::node cfg::_bool record_with_overlays{ this, "Record With Overlays", true, true }; cfg::_bool disable_hardware_texel_remapping{ this, "Disable Hardware ColorSpace Remapping", false, true }; cfg::uint<0, 100> rcas_sharpening_intensity{ this, "FidelityFX CAS Sharpening Intensity", 50, true }; - cfg::_bool allow_blit_engine_upscaling{ this, "Allow Blit Engine Upscaling", false, true }; + cfg::_bool disable_blit_engine_upscaling{ this, "Disable Blit Engine Upscaling", false, true }; struct node_vk : cfg::node { diff --git a/rpcs3/rpcs3qt/emu_settings_type.cpp b/rpcs3/rpcs3qt/emu_settings_type.cpp index 0a4cb6ba7d97..8c5b81d668ed 100644 --- a/rpcs3/rpcs3qt/emu_settings_type.cpp +++ b/rpcs3/rpcs3qt/emu_settings_type.cpp @@ -113,7 +113,7 @@ const std::map settings_location = { emu_settings_type::RecordWithOverlays, get_cfg_location(local_cfg.video.record_with_overlays) }, { emu_settings_type::DisableHWTexelRemapping, get_cfg_location(local_cfg.video.disable_hardware_texel_remapping) }, { emu_settings_type::FsrSharpeningStrength, get_cfg_location(local_cfg.video.rcas_sharpening_intensity) }, - { emu_settings_type::EnableBlitEngineScaling, get_cfg_location(local_cfg.video.allow_blit_engine_upscaling) }, + { emu_settings_type::DisableBlitEngineScaling, get_cfg_location(local_cfg.video.disable_blit_engine_upscaling) }, // Vulkan { emu_settings_type::VulkanAdapter, get_cfg_location(local_cfg.video.vk.adapter) }, diff --git a/rpcs3/rpcs3qt/emu_settings_type.h b/rpcs3/rpcs3qt/emu_settings_type.h index 74fdb4dd3b49..d7a7300e40c0 100644 --- a/rpcs3/rpcs3qt/emu_settings_type.h +++ b/rpcs3/rpcs3qt/emu_settings_type.h @@ -112,7 +112,7 @@ enum class emu_settings_type UseReBAR, RecordWithOverlays, DisableHWTexelRemapping, - EnableBlitEngineScaling, + DisableBlitEngineScaling, // Anaglyph Matrix CustomAnaglyphMatrixLeft, diff --git a/rpcs3/rpcs3qt/settings_dialog.cpp b/rpcs3/rpcs3qt/settings_dialog.cpp index 58f98e785c7f..ad83f2e90fd1 100644 --- a/rpcs3/rpcs3qt/settings_dialog.cpp +++ b/rpcs3/rpcs3qt/settings_dialog.cpp @@ -600,7 +600,7 @@ settings_dialog::settings_dialog(std::shared_ptr gui_settings, std EnhanceCheckBox(emu_settings_type::VulkanAsyncTextureUploads, ui->asyncTextureStreaming, tooltips.settings.async_texture_streaming); - m_emu_settings->EnhanceCheckBox(ui->blitEngineScaling, emu_settings_type::EnableBlitEngineScaling); + m_emu_settings->EnhanceCheckBox(ui->blitEngineScaling, emu_settings_type::DisableBlitEngineScaling); SubscribeTooltip(ui->blitEngineScaling, tooltips.settings.blit_engine_scaling); // Radio buttons diff --git a/rpcs3/rpcs3qt/settings_dialog.ui b/rpcs3/rpcs3qt/settings_dialog.ui index bcf7b4326f28..48954ea99a3d 100644 --- a/rpcs3/rpcs3qt/settings_dialog.ui +++ b/rpcs3/rpcs3qt/settings_dialog.ui @@ -996,13 +996,6 @@ - - - - Allow Blit Engine Upscaling - - - @@ -4457,6 +4450,13 @@ + + + + Disable Blit Engine Upscaling + + + diff --git a/rpcs3/rpcs3qt/tooltips.h b/rpcs3/rpcs3qt/tooltips.h index b9ca2aa20b3c..11906ed13a86 100644 --- a/rpcs3/rpcs3qt/tooltips.h +++ b/rpcs3/rpcs3qt/tooltips.h @@ -217,7 +217,7 @@ class Tooltips : public QObject const QString texture_lod_bias = tr("Changes Texture sampling accuracy. (Small changes have a big effect.)\nAvoid using values outside the range of -12 to +12 if you're unsure.\n-3 to +3 is plenty for most usecases"); - const QString blit_engine_scaling = tr("Allow upscaling to affect the RSX image scaling and rotation engine (NV3089) output images.\nThis can allow upscaling to work on some games where it normally doesn't work, but can also cause visual artifacts in other titles."); + const QString blit_engine_scaling = tr("Disable upscaling on the RSX image scaling and rotation engine (NV3089) output images.\nThis may fix some bugs that are present when upscaling is being used, but some games will appear as if they're running at 100% resolution regardless of the real setting."); // gui