[Mac OS X] Fix get_aligned_buf() crashes with ISOs - #19345
Merged
Conversation
Contributor
|
Looks like there already is a fix in |
Contributor
|
@schm1dtmac it was fixed in #19233. you could possibly test that PR also for BD Drive support |
kd-11
reviewed
Aug 29, 2026
Contributor
|
too late. anyway the * 2 was originally used on Windows just to align to 4096 (typical disk block size) but the BD block size (2048) is ok so we can also do the same on Linux and macos. I will apply the changes in #19233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug ticked me off as it causes the entire emulator to persistently crash on launch if any valid ISOs get read in ~/Library/Application Support/rpcs3/games/.
Turns out it's another case of aligned allocations being downright broken on Mac OS X compared to other platforms so I copied over the existing workaround already used in aligned_malloc.hpp (dating back to PR #17800).Or maybe it's as simple as the size not being a multiple of the alignment, guh. Needs review from @kd-11.