Skip to content

rsx: Minor sync improvements - #19353

Merged
kd-11 merged 6 commits into
RPCS3:masterfrom
kd-11:2026/blit-engine-sync
Aug 30, 2026
Merged

rsx: Minor sync improvements#19353
kd-11 merged 6 commits into
RPCS3:masterfrom
kd-11:2026/blit-engine-sync

Conversation

@kd-11

@kd-11 kd-11 commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Adds a few more sync-points and fixes some correctness problems in some places. Also optimizes the async MM subsystem a lot for performance reasons.

Closes #19344

@digant73

Copy link
Copy Markdown
Contributor

fixes #16617

@LoweysLitsman

Copy link
Copy Markdown
Contributor

Seems to also fix the regression LittleBigPlanet 3 screen tearing mentioned in #19346
Should probably wait for confirmation on puppeteer before closing it.

@LoweysLitsman

Copy link
Copy Markdown
Contributor

The Last of Us doesn't seem to flicker/shake anymore in this early part of the game.

TLOU.KD.-.PR.19353.mp4
How it looked previously

Master 19845

TLOU.KD.-.MASTER.19845.mp4

MASTER 19872 or PR 19013

TLOU.KD.-.MASTER.19872.or.PR.19013.mp4

@AniLeo

AniLeo commented Aug 30, 2026

Copy link
Copy Markdown
Member
Screenshot_20260830_045541

Twisted Metal is around 8 FPS slower for me

@kd-11

kd-11 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author
Screenshot_20260830_045541 Twisted Metal is around 8 FPS slower for me

Can you check which commit? Only the last one is strictly needed for twisted metal so you can remove the others and check. My cpu isn't powerful enough for RSX to show any meaningful changes.

@AniLeo

AniLeo commented Aug 30, 2026

Copy link
Copy Markdown
Member
Screenshot_20260830_045541 Twisted Metal is around 8 FPS slower for me

Can you check which commit? Only the last one is strictly needed for twisted metal so you can remove the others and check. My cpu isn't powerful enough for RSX to show any meaningful changes.

I removed the first two commits and there's no performance difference vs. the three commits. So I'm afraid the last one is the one that also kills performance.

@Megamouse Megamouse added the RSX label Aug 30, 2026
@AniLeo

AniLeo commented Aug 30, 2026

Copy link
Copy Markdown
Member

It's an issue with the GPU blit path, since enabling CPU blit with the 4 buffer options also works on master and has significantly higher performance, it's just around 2-3 FPS slower.

@kd-11
kd-11 marked this pull request as draft August 30, 2026 20:05
@kd-11
kd-11 force-pushed the 2026/blit-engine-sync branch from c686afd to 3db8cf5 Compare August 30, 2026 21:49
@kd-11
kd-11 marked this pull request as ready for review August 30, 2026 21:49
@kd-11

kd-11 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

I removed the commits that don't improve anything for the moment, They'll be pushed in a different PR to keep the hotfix from getting blocked.

@kd-11
kd-11 enabled auto-merge (rebase) August 30, 2026 21:55
@kd-11
kd-11 merged commit d267b42 into RPCS3:master Aug 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression] Twisted Metal infinite loading screen (#19013)

5 participants