fix cctype usage - #19379
Open
Megamouse wants to merge 2 commits into
Open
Conversation
kd-11
reviewed
Sep 2, 2026
elad335
reviewed
Sep 2, 2026
| std::strlen(systemVersion.get_ptr()) == 7 && | ||
| std::isdigit(systemVersion[0]) && | ||
| std::isdigit(systemVersion[1]) && | ||
| std::isdigit(static_cast<uchar>(systemVersion[0])) && |
Contributor
There was a problem hiding this comment.
You can add an alternative function it to util/types.hpp
This was already "fixed" multiple times in the past, need a pernament solution.
Contributor
Author
There was a problem hiding this comment.
Added cctype.hpp + unit test.
I hope none of the places actually depended on the std (<locale>) versions
Megamouse
force-pushed
the
isdigit
branch
4 times, most recently
from
September 2, 2026 21:18
34e0b40 to
a3600c6
Compare
According to the documentation, we should cast to unsigned char. Anything negative is undefined behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation, we should cast to unsigned char. Anything negative is undefined behavior.