[Mac OS X] Fix sys_ss_random_number_generator & cleanup some dead code - #19382
Merged
Conversation
elad335
enabled auto-merge (rebase)
September 2, 2026 04:32
elad335
disabled auto-merge
September 2, 2026 04:33
Megamouse
reviewed
Sep 2, 2026
schm1dtmac
force-pushed
the
macosxfix
branch
from
September 2, 2026 11:22
4ec19c7 to
56f7213
Compare
elad335
enabled auto-merge (squash)
September 2, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19381, ignored OP's AI generated comment and had a look myself since VSH also exhibits the same issue (if it didn't, I'd have been worried as honestly I'd think VSH is the #1 user of random number generation 😂), seems to just be a case of very loose detection of what classes as an optical disk on Mac OS X, I've checked online and everything suggests they're only ever mounted as /dev/disk (and /dev/rdisk respectively for the raw device) so a check for "disk" should be enough to fix this up. (Also cleaned up a dead line of code in rpcs3.cpp too relating to unsupported Mac OS X versions, too minor to be worth doing elsewhere).