Fix PKG path traversal and oversized entry allocation - #19385
Open
acts-1631 wants to merge 3 commits into
Open
Conversation
PKG entry names could contain traversal components and escape the installation directory. Reject absolute and special components, then require the resolved target to remain below the installation root before creating or writing files.
PKG file_count was used for vector allocation before validating that the encrypted package data contained the entry table. Limit the count and require the entry table to fit in the declared data region before allocating.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two issues in PKG package handling.
PKG entry paths could escape the installation directory through traversal
components. Validate entry paths and require resolved destinations to remain
within the installation root.
PKG file_count could trigger a large allocation before the entry table was
validated. Limit the count and require the table to fit within package data.