Reject overflowing savestate collection counts - #19386
Merged
Merged
Conversation
elad335
self-requested a review
September 2, 2026 18:28
Contributor
|
This also fixes UB when decoding signed integers when MSB is set, good job. |
elad335
enabled auto-merge (rebase)
September 3, 2026 09:14
Contributor
Author
|
Thanks goku |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The savestate compatibility check trusts the collection length encoded in the file. For bitwise-serializable vectors, the length is multiplied by the element size before reading the data. That multiplication can wrap, allowing a small input to pass the read check and then trigger an enormous vector resize.
This adds checked VLE decoding and rejects collection sizes whose serialized byte count cannot be represented. Normal savestates retain the existing format, while truncated or oversized data is rejected.