Bounds-check Cg binary byte swapping - #19387
Merged
Merged
Conversation
elad335
enabled auto-merge (rebase)
September 2, 2026 18:38
|
I'm having a problem with this build and the previous ones (after v0.0.42-19845), especially in Army of TWO: The 40th Day. It stutters a lot and when the aggro bar is rising, the screen glitches like in the video down below. Bug.RPCS3.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cg disassembler can be opened on any file with an
.fpoor.vpoextension. When the file indicates a big-endian shader,ConvertToLEswaps a fixed-size header and several offset-based ranges without checking that they fit in the loaded file. A short or malformed file can therefore write pastm_buffer.This adds bounds checks for the header, parameter table, microcode, and program header. Invalid files are ignored by the disassembler instead of being processed.