Big picture: fix crashes and unwanted exit - #19389
Merged
Merged
Conversation
We need to init the input handlers, otherwise we have a chance to crash when the fxo is used in some input loop
This is the default behavior of the home_menu_page, which was only intended for use during gameplay originally. We also expect the game grid to have a parent.
We don't want to change UI elements while we are compiling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize missing input handlers
We need to init the input handlers, otherwise we have a chance to crash when the fxo is used in some input loop.
This is easily observed on opengl, where we probably handle threading a bit differently.
Do not exit big picture with circle button
This is the default behavior of the home_menu_page, which was only intended for use during gameplay originally.
We also expect the game grid to have a parent.
Add lock to handle_button_press
We don't want to change UI elements while we are compiling.