Reject overflowing ELF section ranges - #19393
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When RPCS3 loads an ELF,
elf::loadtries to reuse data already read for each loadable section by creatingbin_viewinto the matching program-header buffer. The range check adds attacker-controlled section offsets and sizes to segment bounds, so integer wraparound can make an invalid section appear to fit. Callers such asppu_load_rel_execlater copy that view into emulated memory, causing a host out-of-bounds read for a malformed ELF.Replace the checks in both the load and save paths with subtraction-based bounds checks. These verify that the section size fits in the segment and that its offset remains within the available segment bytes without overflowing.