Skip to content

Validate SCE metadata header sizes #19394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elad335 merged 2 commits into from
Sep 3, 2026
+28 −2
Merged

Validate SCE metadata header sizes #19394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13e50b
Validate SELF metadata header sizes
acts-1631 Sep 3, 2026
6fd68b7
Merge branch 'master' into self-metadata-length-fix
elad335 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions rpcs3/Crypto/unself.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,20 @@ bool SCEDecrypter::LoadMetadata(const u8 erk[32], const u8 riv[16])
{
aes_context aes;
std::vector<u8> metadata_info(sizeof(meta_info));
std::vector<u8> metadata_headers(sce_hdr.se_hsize - (sizeof(sce_hdr) + sce_hdr.se_meta + sizeof(meta_info)));
constexpr usz sizeof_meta_and_header = sizeof(meta_info) + sizeof(sce_hdr);
const usz metadata_offset = static_cast<usz>(sce_hdr.se_meta);

if (metadata_offset > usz{umax} - sizeof_meta_and_header ||
sce_hdr.se_hsize < sizeof_meta_and_header + metadata_offset ||
sce_hdr.se_hsize - (sizeof_meta_and_header + metadata_offset) < sizeof(meta_hdr) ||
sce_hdr.se_hsize > sce_f.size())
{
self_log.error("Invalid SCE metadata header size!");
return false;
}

const usz metadata_headers_offset = sizeof_meta_and_header + metadata_offset;
std::vector<u8> metadata_headers(sce_hdr.se_hsize - metadata_headers_offset);

// Locate and read the encrypted metadata info.
sce_f.seek(sce_hdr.se_meta + sizeof(sce_hdr));
Expand Down Expand Up @@ -1123,7 +1136,20 @@ bool SELFDecrypter::LoadMetadata(const u8* klic_key)
{
aes_context aes;
std::vector<u8> metadata_info(sizeof(meta_info));
std::vector<u8> metadata_headers(sce_hdr.se_hsize - (sizeof(sce_hdr) + sce_hdr.se_meta + sizeof(meta_info)));
constexpr usz sizeof_meta_and_header = sizeof(meta_info) + sizeof(sce_hdr);
const usz metadata_offset = static_cast<usz>(sce_hdr.se_meta);

if (metadata_offset > usz{umax} - sizeof_meta_and_header ||
sce_hdr.se_hsize < sizeof_meta_and_header + metadata_offset ||
sce_hdr.se_hsize - (sizeof_meta_and_header + metadata_offset) < sizeof(meta_hdr) ||
sce_hdr.se_hsize > self_f.size())
{
self_log.error("Invalid SELF metadata header size!");
return false;
}

const usz metadata_headers_offset = sizeof_meta_and_header + metadata_offset;
std::vector<u8> metadata_headers(sce_hdr.se_hsize - metadata_headers_offset);

// Locate and read the encrypted metadata info.
self_f.seek(sce_hdr.se_meta + sizeof(sce_hdr));
Expand Down
Loading