SaveStates: Reject unrealistic memory allocations - #19395
Merged
Conversation
Megamouse
reviewed
Sep 3, 2026
elad335
enabled auto-merge (rebase)
September 3, 2026 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #19386
While protection against overflow has been added, protection against false (due to corruption) allocations which can cause RAM shortage can still happen.
This affects the loading stage of savestates, where the size of arrays is loaded from the file.
I have limited dynamic allocations to be 256MB at maximum which correlates to the maximum PS3 memory single allocation size.
Even that is unrealistic 99% of the time, but it protects against RPCS3 crashing due to memory bottlenecking until the FXO verifications tell us that indeed there is corruption and stop deserialization altogether before anything bad happens.
Unique limits to each dynamic container deserialization call may be added in the future.