Bound Clans member attribute encoding - #19399
Merged
Merged
Conversation
RipleyTom
approved these changes
Sep 4, 2026
elad335
enabled auto-merge (rebase)
September 4, 2026 05:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Clans client handles
sceNpClansUpdateMemberInfo,clans_client::update_member_infoBase64-encodes the guest-providedbinAttr1usingbinData1Size.binAttr1is a fixed 16-byte array, but the size was passed through unchecked and the output capacity was set toUINT32_MAX. A guest can provide a larger length, causing WolfSSL to read beyond the fixed attribute and write past the 33-byte stack buffer.Reject sizes larger than
binAttr1before encoding and pass the actual output-buffer capacity to WolfSSL. Encoding failures are returned as invalid arguments.