Skip to content

Bound Clans member attribute encoding #19399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elad335 merged 2 commits into from
Sep 4, 2026
+6 −3
Merged

Bound Clans member attribute encoding #19399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15f64d9
Bound Clans member attribute encoding
acts-1631 Sep 3, 2026
5f5b8ea
Merge branch 'master' into clans-member-base64-fix
elad335 Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rpcs3/Emu/NP/clans_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,11 +932,14 @@ namespace clan

pugi::xml_node status = clan.append_child("bin-attr1"sv);

const u32 bin_data_size = static_cast<u32>(info.binData1Size);
if (bin_data_size > sizeof(info.binAttr1))
return SCE_NP_CLANS_ERROR_INVALID_ARGUMENT;

byte bin_attr_1[SCE_NP_CLANS_MEMBER_BINARY_ATTRIBUTE1_MAX_SIZE * 2 + 1] = {0};
uint32_t bin_attr_1_size = UINT32_MAX;
Base64_Encode_NoNl(info.binAttr1, info.binData1Size, bin_attr_1, &bin_attr_1_size);
uint32_t bin_attr_1_size = sizeof(bin_attr_1);

if (bin_attr_1_size == UINT32_MAX)
if (Base64_Encode_NoNl(info.binAttr1, bin_data_size, bin_attr_1, &bin_attr_1_size) != 0)
return SCE_NP_CLANS_ERROR_INVALID_ARGUMENT;

// `reinterpret_cast` used to let the compiler select the correct overload of `set`
Expand Down
Loading