-
Notifications
You must be signed in to change notification settings - Fork 139
Fix blocked webpage fetches with a requests fallback #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LIMINGNING
wants to merge
3
commits into
RUC-NLPIR:main
Choose a base branch
from
LIMINGNING:fix/web-fetch-requests-fallback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| import asyncio | ||
| import os | ||
| import sys | ||
| import unittest | ||
| from unittest.mock import AsyncMock, Mock, patch | ||
|
|
||
|
|
||
| SCRIPTS_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__))) | ||
| if SCRIPTS_DIR not in sys.path: | ||
| sys.path.insert(0, SCRIPTS_DIR) | ||
|
|
||
| from search.bing_search import ( # noqa: E402 | ||
| WIKIMEDIA_USER_AGENT, | ||
| extract_text_from_url_async, | ||
| fetch_with_requests_fallback, | ||
| request_headers_for_url, | ||
| ) | ||
|
|
||
|
|
||
| class WebFetchFallbackTests(unittest.TestCase): | ||
| def test_wikimedia_uses_descriptive_user_agent_without_google_referer(self): | ||
| request_headers = request_headers_for_url( | ||
| "https://en.wikipedia.org/wiki/Mercedes_Sosa" | ||
| ) | ||
| self.assertEqual(request_headers["User-Agent"], WIKIMEDIA_USER_AGENT) | ||
| self.assertNotIn("Referer", request_headers) | ||
|
|
||
| def test_other_domains_keep_existing_browser_headers(self): | ||
| request_headers = request_headers_for_url("https://example.com/article") | ||
| self.assertIn("Mozilla/5.0", request_headers["User-Agent"]) | ||
| self.assertEqual(request_headers["Referer"], "https://www.google.com/") | ||
|
|
||
| def test_requests_fallback_runs_off_the_async_event_loop(self): | ||
| with patch( | ||
| "search.bing_search.extract_text_from_url", | ||
| return_value="fallback page text", | ||
| ) as fetch: | ||
| result = asyncio.run( | ||
| fetch_with_requests_fallback( | ||
| "https://example.com/article", | ||
| snippet="relevant snippet", | ||
| ) | ||
| ) | ||
|
|
||
| self.assertEqual(result, "fallback page text") | ||
| fetch.assert_called_once_with( | ||
| "https://example.com/article", | ||
| False, | ||
| None, | ||
| "relevant snippet", | ||
| False, | ||
| ) | ||
|
LIMINGNING marked this conversation as resolved.
|
||
|
|
||
| def test_async_fetch_failure_uses_requests_fallback(self): | ||
| async def run_test(): | ||
| session = Mock() | ||
| session.get.side_effect = asyncio.TimeoutError() | ||
|
|
||
| with patch( | ||
| "search.bing_search.fetch_with_requests_fallback", | ||
| new_callable=AsyncMock, | ||
| return_value="fallback page text", | ||
| ) as fallback: | ||
| result = await extract_text_from_url_async( | ||
| "https://example.com/article", | ||
| session, | ||
| snippet="relevant snippet", | ||
| ) | ||
|
|
||
| self.assertEqual(result, "fallback page text") | ||
| fallback.assert_awaited_once_with( | ||
| "https://example.com/article", | ||
| use_jina=False, | ||
| jina_api_key=None, | ||
| snippet="relevant snippet", | ||
| keep_links=False, | ||
| ) | ||
|
|
||
| asyncio.run(run_test()) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.