Remove canonical vertices, the incidence weld filter and the tree space plane cache (#60)

* Use only ASCII in comments

* Refer to generated object names by their searchable part in comments

* Remove canonical vertices, the incidence weld filter and the tree space plane cache

Canonical vertices were an experiment for the old CSG path and never shipped
(stage 0, off). Removed with them: the incidence weld filter (also an old path
experiment, off), the HashedVertices overloads that took it, and the tree space
plane cache, which only those read.

The base polygons are built as before: corners as they are, snapped onto the
corners of the brushes touching them (the hotspot caps read those corners).

Fixes #59

Author: LogicalError

Components/Tests/ChiselMaterialMeshTests.cs

@@ -186,7 +186,7 @@ public void AChunk_IsNotSplit_InAModelLitByProbes()
             Assert.That(RenderersOf(model, first).Count, Is.EqualTo(1), "one mesh for the 32 m cell");
         }
 
-        // Three boxes of about 6 m² of lightmap each: with room for 15, their 32 m cell (18) splits into its 16 m cells (12 and 6)
+        // Three boxes of about 6 m^2 of lightmap each: with room for 15, their 32 m cell (18) splits into its 16 m cells (12 and 6)
         [Test]
         public void ASplitStopsAtTheCellsThatFit()
         {

Core/1.Input/BrushMesh/BrushMesh.Utility.cs

@@ -655,7 +655,7 @@ static bool SplitPolygon(int polygonIndex, List<VertexSide> vertexDistances, Lis
                     intersections[i0] = planeTraversal0;
                 }
 
-                // NOTE: from this point on Traversal𝑛.EdgeIndex may no longer be valid!
+                // NOTE: from this point on TraversalN.EdgeIndex may no longer be valid!
 
 
                 Debug.Assert((intersections.Count & 1) != 1, "Found an uneven number of edge-plane traversals??");

Core/1.Input/Nodes/CSGTree.cs

@@ -199,7 +199,7 @@ public bool InsertRange(int index, NativeArray<CSGTreeNode> array)
 
         /// <summary>Determines the index of a specific child in the <see cref="Chisel.Core.CSGTree"/>.</summary>
         /// <param name="item">The <see cref="Chisel.Core.CSGTreeNode"/> to locate in the <see cref="Chisel.Core.CSGTree"/>.</param>
-        /// <returns>The index of <paramref name="item"/> if found in the <see cref="Chisel.Core.CSGTree"/>; otherwise, –1.</returns>
+        /// <returns>The index of <paramref name="item"/> if found in the <see cref="Chisel.Core.CSGTree"/>; otherwise, -1.</returns>
         public int  IndexOf		(CSGTreeNode item)					{ return Hierarchy.SiblingIndexOf(CompactNodeID, item.CompactNodeID); }
 
         /// <summary>Determines whether the <see cref="Chisel.Core.CSGTree"/> contains a specific value.</summary>

Core/1.Input/Nodes/CSGTreeBranch.cs

@@ -217,7 +217,7 @@ public bool InsertRange(int index, NativeArray<CSGTreeNode> array)
 
         /// <summary>Determines the index of a specific child in the <see cref="Chisel.Core.CSGTreeBranch"/>.</summary>
         /// <param name="item">The <see cref="Chisel.Core.CSGTreeNode"/> to locate in the <see cref="Chisel.Core.CSGTreeBranch"/>.</param>
-        /// <returns>The index of <paramref name="item"/> if found in the <see cref="Chisel.Core.CSGTreeBranch"/>; otherwise, –1.</returns>
+        /// <returns>The index of <paramref name="item"/> if found in the <see cref="Chisel.Core.CSGTreeBranch"/>; otherwise, -1.</returns>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public int  IndexOf		(CSGTreeNode item)              { return Hierarchy.SiblingIndexOf(CompactNodeID, item.CompactNodeID); }
 

Core/2.Processing/Algorithms/MeshAlgorithms.cs

@@ -410,7 +410,7 @@ public void RemoveSelfIntersectingEdges()
 			for (int i = 0; i < edgeCount; i++)
 				removeFlags[i] = false;
 
-			// Mark any pair of non‐adjacent edges that intersect
+			// Mark any pair of non-adjacent edges that intersect
 			for (int i = 0; i < edgeCount; ++i)
 			{
 				int p1i = edgeIndices[i * 2 + 0];

Core/2.Processing/Cache/ChiselLookup.cs

@@ -24,7 +24,6 @@ public class Data
             public NativeList<BlobAssetReference<ChiselBrushRenderBuffer>>      brushRenderBufferCache;
 
             public NativeList<MinMaxAABB>                                       brushTreeSpaceBoundCache;
-            public NativeList<BlobAssetReference<BrushTreeSpacePlanes>>         brushTreeSpacePlaneCache;
             public NativeList<BlobAssetReference<BrushesTouchedByBrush>>        brushesTouchedByBrushCache;
             // Each brush as the exact CSG sees it (ExactBrush: exact planes, corners, bounds), rebuilt when the brush
             // changes (ExactInputJob).
@@ -72,7 +71,6 @@ internal void Initialize()
 				basePolygonCache            = new NativeList<BlobAssetReference<BasePolygonsBlob>>(1000, Allocator.Persistent); // Confirmed to get disposed
 				treeSpaceVerticesCache      = new NativeList<BlobAssetReference<BrushTreeSpaceVerticesBlob>>(1000, Allocator.Persistent); // Confirmed to get disposed
 				routingTableCache           = new NativeList<BlobAssetReference<RoutingTable>>(1000, Allocator.Persistent); // Confirmed to get disposed
-				brushTreeSpacePlaneCache    = new NativeList<BlobAssetReference<BrushTreeSpacePlanes>>(1000, Allocator.Persistent); // Confirmed to get disposed
 				brushesTouchedByBrushCache  = new NativeList<BlobAssetReference<BrushesTouchedByBrush>>(1000, Allocator.Persistent); // Confirmed to get disposed
 				brushRenderBufferCache      = new NativeList<BlobAssetReference<ChiselBrushRenderBuffer>>(1000, Allocator.Persistent); // Confirmed to get disposed
 				exactBrushCache             = new NativeList<BlobAssetReference<ExactBrush>>(1000, Allocator.Persistent);
@@ -115,8 +113,6 @@ internal void EnsureCapacity(int brushCount)
                 if (routingTableCache.Capacity < brushCount)
                     routingTableCache.Capacity = brushCount;
 
-                if (brushTreeSpacePlaneCache.Capacity < brushCount)
-                    brushTreeSpacePlaneCache.Capacity = brushCount;
 
                 if (brushesTouchedByBrushCache.Capacity < brushCount)
                     brushesTouchedByBrushCache.Capacity = brushCount;
@@ -182,19 +178,6 @@ internal void Dispose()
                     routingTableCache.Dispose();
                 }
                 routingTableCache = default;
-                if (brushTreeSpacePlaneCache.IsCreated)
-				{
-                    // Confirmed to be called
-					for (int i = 0; i < brushTreeSpacePlaneCache.Length; i++)
-                    {
-                        if (brushTreeSpacePlaneCache[i].IsCreated)
-							brushTreeSpacePlaneCache[i].Dispose();
-                        brushTreeSpacePlaneCache[i] = default;
-                    }
-                    brushTreeSpacePlaneCache.Clear();
-                    brushTreeSpacePlaneCache.Dispose();
-                }
-                brushTreeSpacePlaneCache = default;
                 if (brushesTouchedByBrushCache.IsCreated)
 				{
                     // Confirmed to be called