Repository navigation
Keep the handles of a brush with an invalid shape - #66
Merged
Merged
Conversation
The editable outline only needs whole topology, not a valid shape: a brush dragged into a concave or flat shape keeps its handles, drawn in the invalid color, and can be dragged back. A brush's shape errors aren't logged any more (they come with every drag while the shape is invalid); the inspector shows them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12. Thanks @klapstoelpiloot for the report.
A brush dragged into an invalid shape (concave, flat) disappeared together with its handles, so it couldn't be dragged back. The editable outline asked for a valid shape where it only needs whole topology; it now keeps its handles, drawn in the invalid color, and the brush can be dragged back into a valid shape. The brush itself is still left out of the CSG while its shape is invalid, and deselecting it while invalid still reverts the change.
A brush's shape errors are no longer logged to the console: they came with every drag frame while the shape was invalid. The inspector and the hierarchy still show them.
Test: a concave brush keeps its handles (fails without the fix). Full suite: 2006 tests, all passing.