[Kong#11][feature] Fixed bug with short and query

Author: therebelrobot

src/targets/node/request.js

@@ -63,8 +63,15 @@ module.exports = function(options) {
   else {
     reqOpts.body = this.source.postData.params;
   }
-  var simpleRequest = this.source.bodySize === 0 && this.source.headerSize === 0;
 
+  var simpleRequest = 
+    this.source.cookies.length === 0 && 
+    this.source.headers.length === 0 && (
+      !this.source.postData.params ||
+      this.source.postData.params.length === 0
+    );
+  console.log(simpleRequest, this.source, simpleRequest)
+  
   // construct cookies argument
   var cookies = this.source.cookies.map(function(cookie) {
     return encodeURIComponent(cookie.name) + '=' + encodeURIComponent(cookie.value);
@@ -79,13 +86,14 @@ module.exports = function(options) {
     code.push('var fs = require(\'fs\');');
   }
 
-  code.push(null);
+  if(!simpleRequest) code.push(null);
 
   var options = !simpleRequest ? util.format('var options = %s;', JSON.stringify(reqOpts, null, opts.indent)) : null;
   fsReplace.forEach(function(fsToReplace) {
     options = options.replace('"' + fsToReplace + '"', fsToReplace);
   })
-  code.push(options);
+
+  if(!simpleRequest) code.push(options);
 
   code.push(null);
   var requestLine = 'request.';

test/fixtures/output/node/request/query.js

@@ -1,11 +1,6 @@
 var request = require('request');
 
-var options = {
-  "url": "http://mockbin.com/har?key=value&baz=abc&foo=bar&foo=baz",
-  "headers": {}
-};
-
-request.get(options, function(error, response, body){
+request.get('http://mockbin.com/har?key=value&baz=abc&foo=bar&foo=baz', function(error, response, body){
   if(error) throw new Error(error);
 
 });

test/fixtures/output/node/request/short.js

@@ -1,11 +1,6 @@
 var request = require('request');
 
-var options = {
-  "url": "http://mockbin.com/har",
-  "headers": {}
-};
-
-request.get(options, function(error, response, body){
+request.get('http://mockbin.com/har', function(error, response, body){
   if(error) throw new Error(error);
 
 });