Repository navigation
Fail closed in make-xcframeworks.sh - #2736
Open
TastyHeadphones wants to merge 1 commit into
Open
TastyHeadphones wants to merge 1 commit into
TastyHeadphones wants to merge 1 commit into
Conversation
The release script ignored xcodebuild/codesign failures (piped without pipefail) and left stale *.xcframework dirs in place, so a failed run could still zip old frameworks and exit 0. Enable pipefail, clear previous outputs up front, and require each xcframework to exist before signing/zipping. Fixes ReactiveX#2733
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make-xcframeworks.sh could exit 0 and ship a zip of stale *.xcframework dirs even when every xcodebuild/codesign call failed — the pipe to xcbeautify hid the status, and old output dirs were never cleared.
Changes:
Fixes #2733