Fix clock on PlatformIO build - #5
Merged
RoboDurden merged 1 commit intoMay 7, 2025
Merged
Conversation
The PlatformIO build was unintentionally running at the wrong clock source, causing motors to emit a metallic noise. Use __SYSTEM_CLOCK_72M_PLL_IRC8M_DIV2 (as used by the Keil build) This required a little change to gd32-pio-spl-package to add support for __PIO_DONT_SET_CLOCK_SOURCE__ See CommunityGD32Cores/gd32-pio-spl-package#13
Owner
|
Great that you test the platform.io framework! But is it necessary to use your personal GitHub: @https://github.com/hoverboardhavoc/gd32-pio-spl-package.git#hoverboardhavoc/add__PIO_DONT_SET_CLOCK_SOURCE__ ? Maybe I can wait until your pull request over there is accepted. |
Contributor
Author
|
Yes please, add a supporting comment! I thought it would be OK to use my repo until the PR is accepted. It's better than the current situation. |
Owner
|
Done. I will wait 24h now :-) |
Contributor
Author
|
I wonder if Max has moved on to other things? CommunityGD32Cores/gd32-pio-spl-package#13 was Max's own fix that he applied to the Arduino repo. There is another PR that's been there since last August 😢 CommunityGD32Cores/gd32-pio-spl-package#12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PlatformIO build was unintentionally running at the wrong clock source, causing motors to emit a metallic noise.
Use __SYSTEM_CLOCK_72M_PLL_IRC8M_DIV2 (as used by the Keil build)
This required a little change to gd32-pio-spl-package to add support for PIO_DONT_SET_CLOCK_SOURCE
See CommunityGD32Cores/gd32-pio-spl-package#13