Skip to content

Commit 0e993fd

Browse files
jfrench9claude
andauthored
Refactor connections, remove Plaid, add view creation API (#66)
## Summary This PR refactors the connection subsystem by removing Plaid integration, streamlining the element mapping architecture, and introducing a new View creation API with supporting models. The changes simplify the SDK surface area while adding new view-building capabilities. ## Key Accomplishments ### Plaid Integration Removal - Removed `PlaidConnectionConfig` model and all Plaid-specific references from connection-related files - Cleaned up Plaid provider references from `ConnectionProviderInfoProvider`, `CreateConnectionRequestProvider`, and `ListConnectionsProviderType0` - Simplified `ConnectionResponse` and `CreateConnectionRequest` models by removing Plaid-specific configuration branches - Streamlined `SecConnectionConfig` model ### Connection API Cleanup - Removed unused functionality from `create_connection`, `get_connection_options`, and `sync_connection` API endpoints - Simplified `list_connections` API ### New View Creation API - Added `api/views/` module with a `create_view` endpoint - Introduced new models: `CreateViewRequest`, `ViewConfig`, `ViewAxisConfig`, `ViewAxisConfigElementLabelsType0`, and `ViewAxisConfigMemberLabelsType0` - Repurposed renamed Plaid model files into view axis config label types (leveraging similar structure) ### Element Mapping Client Removal & View Builder Refactor - Deleted `element_mapping_client.py` (585 lines removed) and removed its export from the extensions module - Streamlined `ViewBuilderClient` by removing element mapping references, enhancing clarity of the view builder's responsibilities - Updated SDK aliases in `__init__.py` to reflect the new module structure ## Breaking Changes ⚠️ **Breaking:** The following removals will affect consumers of this SDK: - **`PlaidConnectionConfig`** model has been removed — any code referencing Plaid connections will break - **`ElementMappingClient`** extension has been deleted — consumers must migrate away from this client - **`ViewBuilderClient`** API surface has changed — element mapping methods are no longer available through this client - **Connection API endpoints** (`create_connection`, `get_connection_options`, `sync_connection`) have reduced functionality — callers passing Plaid-specific parameters will need to be updated - **SDK aliases** in `__init__.py` have been refactored — import paths may need updating ## Testing Notes - Verify that existing connection workflows (non-Plaid providers) continue to function correctly with the simplified models - Test the new `create_view` endpoint with various `ViewConfig` and `ViewAxisConfig` combinations - Confirm that the `ViewBuilderClient` operates correctly without element mapping dependencies - Validate that `SecConnectionConfig` changes are backward-compatible for existing SEC-based connections - Check that all model serialization/deserialization works correctly for the new view-related models ## Infrastructure Considerations - Downstream services and consumers of this SDK should be updated to remove any Plaid-related references before adopting this version - The new views API module requires corresponding backend endpoint availability — ensure the API server supports the `create_view` route before deployment - Consider a coordinated release if other services depend on the removed `ElementMappingClient` functionality --- 🤖 Generated with [Claude Code](https://claude.ai/code) **Branch Info:** - Source: `feature/connection-improvements` - Target: `main` - Type: feature Co-Authored-By: Claude <noreply@anthropic.com>
2 parents bc3e609 + 840e5b6 commit 0e993fd

24 files changed

Lines changed: 923 additions & 995 deletions

‎robosystems_client/__init__.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,14 @@
22

33
from .client import AuthenticatedClient, Client
44

5-
# Convenience alias for the main SDK
5+
# Convenience aliases for the main SDK
6+
RoboSystemsClient = AuthenticatedClient
67
RoboSystemsSDK = AuthenticatedClient
78

89
__all__ = (
910
"AuthenticatedClient",
1011
"Client",
12+
"RoboSystemsClient",
1113
"RoboSystemsSDK",
1214
)
1315

‎robosystems_client/api/connections/create_connection.py‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,6 @@ def sync_detailed(
107107
- Requires admin permissions in QuickBooks
108108
- Complete with OAuth callback
109109
110-
**Plaid Connections**:
111-
- Returns Plaid Link token
112-
- User completes bank authentication
113-
- Exchange public token for access
114-
115110
Note:
116111
This operation is included - no credit consumption required.
117112
@@ -161,11 +156,6 @@ def sync(
161156
- Requires admin permissions in QuickBooks
162157
- Complete with OAuth callback
163158
164-
**Plaid Connections**:
165-
- Returns Plaid Link token
166-
- User completes bank authentication
167-
- Exchange public token for access
168-
169159
Note:
170160
This operation is included - no credit consumption required.
171161
@@ -210,11 +200,6 @@ async def asyncio_detailed(
210200
- Requires admin permissions in QuickBooks
211201
- Complete with OAuth callback
212202
213-
**Plaid Connections**:
214-
- Returns Plaid Link token
215-
- User completes bank authentication
216-
- Exchange public token for access
217-
218203
Note:
219204
This operation is included - no credit consumption required.
220205
@@ -262,11 +247,6 @@ async def asyncio(
262247
- Requires admin permissions in QuickBooks
263248
- Complete with OAuth callback
264249
265-
**Plaid Connections**:
266-
- Returns Plaid Link token
267-
- User completes bank authentication
268-
- Exchange public token for access
269-
270250
Note:
271251
This operation is included - no credit consumption required.
272252

‎robosystems_client/api/connections/get_connection_options.py‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,6 @@ def sync_detailed(
8686
- Chart of accounts, transactions, trial balance
8787
- Real-time sync capabilities
8888
89-
**Plaid**: Bank account connections
90-
- Secure bank authentication via Plaid Link
91-
- Transaction history and balances
92-
- Multi-account support
93-
9489
No credits are consumed for viewing connection options.
9590
9691
Args:
@@ -136,11 +131,6 @@ def sync(
136131
- Chart of accounts, transactions, trial balance
137132
- Real-time sync capabilities
138133
139-
**Plaid**: Bank account connections
140-
- Secure bank authentication via Plaid Link
141-
- Transaction history and balances
142-
- Multi-account support
143-
144134
No credits are consumed for viewing connection options.
145135
146136
Args:
@@ -181,11 +171,6 @@ async def asyncio_detailed(
181171
- Chart of accounts, transactions, trial balance
182172
- Real-time sync capabilities
183173
184-
**Plaid**: Bank account connections
185-
- Secure bank authentication via Plaid Link
186-
- Transaction history and balances
187-
- Multi-account support
188-
189174
No credits are consumed for viewing connection options.
190175
191176
Args:
@@ -229,11 +214,6 @@ async def asyncio(
229214
- Chart of accounts, transactions, trial balance
230215
- Real-time sync capabilities
231216
232-
**Plaid**: Bank account connections
233-
- Secure bank authentication via Plaid Link
234-
- Transaction history and balances
235-
- Multi-account support
236-
237217
No credits are consumed for viewing connection options.
238218
239219
Args:

‎robosystems_client/api/connections/list_connections.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def sync_detailed(
109109
Returns active and inactive connections with their current status.
110110
Connections can be filtered by:
111111
- **Entity**: Show connections for a specific entity
112-
- **Provider**: Filter by connection type (sec, quickbooks, plaid)
112+
- **Provider**: Filter by connection type (sec, quickbooks)
113113
114114
Each connection shows:
115115
- Current sync status and health
@@ -159,7 +159,7 @@ def sync(
159159
Returns active and inactive connections with their current status.
160160
Connections can be filtered by:
161161
- **Entity**: Show connections for a specific entity
162-
- **Provider**: Filter by connection type (sec, quickbooks, plaid)
162+
- **Provider**: Filter by connection type (sec, quickbooks)
163163
164164
Each connection shows:
165165
- Current sync status and health
@@ -204,7 +204,7 @@ async def asyncio_detailed(
204204
Returns active and inactive connections with their current status.
205205
Connections can be filtered by:
206206
- **Entity**: Show connections for a specific entity
207-
- **Provider**: Filter by connection type (sec, quickbooks, plaid)
207+
- **Provider**: Filter by connection type (sec, quickbooks)
208208
209209
Each connection shows:
210210
- Current sync status and health
@@ -252,7 +252,7 @@ async def asyncio(
252252
Returns active and inactive connections with their current status.
253253
Connections can be filtered by:
254254
- **Entity**: Show connections for a specific entity
255-
- **Provider**: Filter by connection type (sec, quickbooks, plaid)
255+
- **Provider**: Filter by connection type (sec, quickbooks)
256256
257257
Each connection shows:
258258
- Current sync status and health

‎robosystems_client/api/connections/sync_connection.py‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,6 @@ def sync_detailed(
112112
- Generates fresh trial balance
113113
- Duration depends on data volume
114114
115-
**Plaid Sync**:
116-
- Retrieves recent bank transactions
117-
- Updates account balances
118-
- Categorizes new transactions
119-
120115
Note:
121116
This operation is included - no credit consumption required.
122117
@@ -172,11 +167,6 @@ def sync(
172167
- Generates fresh trial balance
173168
- Duration depends on data volume
174169
175-
**Plaid Sync**:
176-
- Retrieves recent bank transactions
177-
- Updates account balances
178-
- Categorizes new transactions
179-
180170
Note:
181171
This operation is included - no credit consumption required.
182172
@@ -229,11 +219,6 @@ async def asyncio_detailed(
229219
- Generates fresh trial balance
230220
- Duration depends on data volume
231221
232-
**Plaid Sync**:
233-
- Retrieves recent bank transactions
234-
- Updates account balances
235-
- Categorizes new transactions
236-
237222
Note:
238223
This operation is included - no credit consumption required.
239224
@@ -287,11 +272,6 @@ async def asyncio(
287272
- Generates fresh trial balance
288273
- Duration depends on data volume
289274
290-
**Plaid Sync**:
291-
- Retrieves recent bank transactions
292-
- Updates account balances
293-
- Categorizes new transactions
294-
295275
Note:
296276
This operation is included - no credit consumption required.
297277

‎robosystems_client/api/graphs/get_available_extensions.py‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ def sync_detailed(
6161
**Available Extensions:**
6262
- **RoboLedger**: Complete accounting system with XBRL reporting, general ledger, and financial
6363
statements
64-
- **RoboInvestor**: Investment portfolio management and tracking
64+
- **RoboInvestor**: Investment portfolio management with securities tracking, trade execution, and
65+
risk analysis
6566
- **RoboSCM**: Supply chain management and logistics
6667
- **RoboFO**: Front office operations and CRM
6768
- **RoboHRM**: Human resources management
@@ -114,7 +115,8 @@ def sync(
114115
**Available Extensions:**
115116
- **RoboLedger**: Complete accounting system with XBRL reporting, general ledger, and financial
116117
statements
117-
- **RoboInvestor**: Investment portfolio management and tracking
118+
- **RoboInvestor**: Investment portfolio management with securities tracking, trade execution, and
119+
risk analysis
118120
- **RoboSCM**: Supply chain management and logistics
119121
- **RoboFO**: Front office operations and CRM
120122
- **RoboHRM**: Human resources management
@@ -163,7 +165,8 @@ async def asyncio_detailed(
163165
**Available Extensions:**
164166
- **RoboLedger**: Complete accounting system with XBRL reporting, general ledger, and financial
165167
statements
166-
- **RoboInvestor**: Investment portfolio management and tracking
168+
- **RoboInvestor**: Investment portfolio management with securities tracking, trade execution, and
169+
risk analysis
167170
- **RoboSCM**: Supply chain management and logistics
168171
- **RoboFO**: Front office operations and CRM
169172
- **RoboHRM**: Human resources management
@@ -214,7 +217,8 @@ async def asyncio(
214217
**Available Extensions:**
215218
- **RoboLedger**: Complete accounting system with XBRL reporting, general ledger, and financial
216219
statements
217-
- **RoboInvestor**: Investment portfolio management and tracking
220+
- **RoboInvestor**: Investment portfolio management with securities tracking, trade execution, and
221+
risk analysis
218222
- **RoboSCM**: Supply chain management and logistics
219223
- **RoboFO**: Front office operations and CRM
220224
- **RoboHRM**: Human resources management
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
"""Contains endpoint functions for accessing the API"""

0 commit comments

Comments
 (0)