Repository navigation
docs: rewrite the clients README against the code - #290
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An audit found the facade README largely untrue, including a test command that doesn't exist, env vars nothing reads, and an example that builds invalid Cypher. This rewrites it from 634 to 263 lines around what the clients do, and corrects the main README's claims about streaming, async and errors. No code changes.
Changes
robosystems_client/clients/README.md(rewritten)LedgerClient,InvestorClient,LibraryClientand the document client, which the old file didn't mention.run_tests.py, sixROBOSYSTEMS_*env vars,/health(it'sGET /v1/status),company['name'], connection pooling, automatic caching, "full async throughout" and Python 3.7+.stream_querycollects the whole result before yielding.CookieAuthClientsdoesn't authenticate.get_clients()returns a client for localhost with no credential..where()calls produce invalid Cypher.files.list,files.get,files.deleteandtables.listhide errors.README.mdWorth a close look: this documents limits as they are. Each is a code question for a separate change, not something this PR decides.
Compatibility
None. Documentation only: no export, signature or runtime behavior changes, so no release is needed for code.
Testing
inspect.signature.QueryBuilderoutput, credential routing,max_wait=0and NDJSON aggregation.row["e.name"]relies on the documented column keys, ande.tickerande.sicvalues onsecweren't queried.🤖 Generated with Claude Code