Skip to content

Commit be2e155

Browse files
Merge pull request #1210 from RocketPy-Team/rev/v1.14.0-reverts
REV: revert #1136, #1129 and #1128 before v1.14.0
2 parents ec7b239 + c000b6b commit be2e155

16 files changed

Lines changed: 69 additions & 799 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ Attention: The newest changes should be on top -->
3636
- ENH: 3-DOF single rail button flight phase (tip-off analysis), enabled with the opt-in `Flight(use_udot_rail2=True)`. Between the upper rail button leaving the rail and the lower one following it, the rocket pivots about the lower button under a solved constraint wrench instead of jumping straight to free 6-DOF flight. The window is reported as `between_rails_time`, `between_rails_velocity` and `tip_off_duration`, printed by `Flight.info()` and shaded in the attitude plots. Requires `simulation_mode="6 DOF"` and `equations_of_motion="standard"`. [#920](https://github.com/RocketPy-Team/RocketPy/pull/920)
3737
- ENH: Support fixed-time parachute deployment triggers [#1133](https://github.com/RocketPy-Team/RocketPy/pull/1133) [#437](https://github.com/RocketPy-Team/RocketPy/issues/437)
3838
- DOC: Add SIL parachute ejection integration example [#1131](https://github.com/RocketPy-Team/RocketPy/pull/1131) [#524](https://github.com/RocketPy-Team/RocketPy/issues/524)
39-
- ENH: List NOAA atmosphere datasets and fetch latest [#1136](https://github.com/RocketPy-Team/RocketPy/pull/1136) [#660](https://github.com/RocketPy-Team/RocketPy/issues/660)
4039
- ENH: Model unbonded solid-motor grain CM shift [#1138](https://github.com/RocketPy-Team/RocketPy/pull/1138) [#340](https://github.com/RocketPy-Team/RocketPy/issues/340)
41-
- ENH: Add `Flight` post-step callback across all phases [#1128](https://github.com/RocketPy-Team/RocketPy/pull/1128) [#758](https://github.com/RocketPy-Team/RocketPy/issues/758)
4240
- DOC: Document angle-of-attack drag inputs [#1142](https://github.com/RocketPy-Team/RocketPy/pull/1142)
4341
- ENH: Create ensembles from user-defined profiles [#1141](https://github.com/RocketPy-Team/RocketPy/pull/1141)
4442
- ENH: Add tube-fin aerodynamic surface [#1144](https://github.com/RocketPy-Team/RocketPy/pull/1144)
@@ -53,7 +51,6 @@ Attention: The newest changes should be on top -->
5351
### Changed
5452

5553
- ENH: Number the simulations of a serial Monte Carlo run from zero, as the parallel path already did — the two used to name the same simulation `1, 2, 3` and `0, 1, 2`. The `index` field written into the inputs and outputs rows shifts by one for serial runs, so code reading indices off those files has to expect a run of `n` simulations to be numbered `0` to `n - 1`. An append onto a study written before this release is refused rather than continued, since its rows do not record which root drew them. [#1187](https://github.com/RocketPy-Team/RocketPy/pull/1187)
56-
- MNT: Store the reference-area correction factor on each rocket aero surface component, so it is carried with the surface instead of being recomputed at every lift evaluation. `Rocket.aerodynamic_surfaces`, `rail_buttons` and `sensors` now yield `(component, position, ref_factor)`, so code that unpacks a pair from them (`for surface, position in rocket.aerodynamic_surfaces`) has to take the third field or absorb it. Simulation results are unchanged, and `.rpy` files written before this still load. [#1129](https://github.com/RocketPy-Team/RocketPy/pull/1129) [#561](https://github.com/RocketPy-Team/RocketPy/issues/561)
5754
- ENH: Compute the rocket static margin lazily [#1135](https://github.com/RocketPy-Team/RocketPy/pull/1135) [#780](https://github.com/RocketPy-Team/RocketPy/issues/780)
5855
- DOC: Tighten the comments that came with the sampler seed groups [#1154](https://github.com/RocketPy-Team/RocketPy/pull/1154)
5956
- CI: make the Gemini PR reviewer actually review [#1140](https://github.com/RocketPy-Team/RocketPy/pull/1140)

‎rocketpy/environment/fetchers/__init__.py‎

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,6 @@
3232
fetch_open_meteo_ensemble,
3333
fetch_open_meteo_forecast,
3434
)
35-
from rocketpy.environment.fetchers.noaa_catalog import (
36-
FORECAST_MODELS_CATALOG_URL,
37-
NOAA_MODEL_COLLECTIONS,
38-
THREDDS_OPENDAP_ROOT,
39-
build_noaa_opendap_url,
40-
collection_catalog_url,
41-
fetch_latest_noaa_dataset,
42-
get_latest_noaa_dataset_identifier,
43-
get_latest_noaa_opendap_url,
44-
list_noaa_atmosphere_datasets,
45-
list_noaa_dataset_identifiers,
46-
resolve_noaa_collection_path,
47-
)
4835
from rocketpy.environment.fetchers.opendap_fetchers import (
4936
fetch_aigfs_file_return_dataset,
5037
fetch_cmc_ensemble,
@@ -64,23 +51,18 @@
6451

6552
__all__ = [
6653
"MAX_RETRY_DELAY_SECONDS",
67-
"FORECAST_MODELS_CATALOG_URL",
6854
"METEOMATICS_BASE_URL",
6955
"METEOMATICS_LOGIN_URL",
7056
"METEOMATICS_TIMEOUT_SECONDS",
71-
"NOAA_MODEL_COLLECTIONS",
7257
"OPEN_METEO_ENSEMBLE_MODELS",
7358
"OPEN_METEO_ENSEMBLE_URL",
7459
"OPEN_METEO_FORECAST_URL",
7560
"OPEN_METEO_HISTORICAL_START_DATE",
7661
"OPEN_METEO_HISTORICAL_URL",
7762
"OPEN_METEO_PRESSURE_LEVELS",
7863
"OPEN_METEO_TIMEOUT_SECONDS",
79-
"THREDDS_OPENDAP_ROOT",
8064
"MeteomaticsFetcher",
8165
"build_hourly_variables",
82-
"build_noaa_opendap_url",
83-
"collection_catalog_url",
8466
"fetch_aigfs_file_return_dataset",
8567
"fetch_atmospheric_data_from_meteomatics",
8668
"fetch_atmospheric_data_from_windy",
@@ -89,21 +71,15 @@
8971
"fetch_gfs_file_return_dataset",
9072
"fetch_hiresw_file_return_dataset",
9173
"fetch_hrrr_file_return_dataset",
92-
"fetch_latest_noaa_dataset",
9374
"fetch_meteomatics_token",
9475
"fetch_nam_file_return_dataset",
9576
"fetch_open_elevation",
9677
"fetch_open_meteo_ensemble",
9778
"fetch_open_meteo_forecast",
9879
"fetch_rap_file_return_dataset",
9980
"fetch_wyoming_sounding",
100-
"get_latest_noaa_dataset_identifier",
101-
"get_latest_noaa_opendap_url",
102-
"list_noaa_atmosphere_datasets",
103-
"list_noaa_dataset_identifiers",
10481
"logger",
10582
"netCDF4",
10683
"requests",
107-
"resolve_noaa_collection_path",
10884
"time",
10985
]

0 commit comments

Comments
 (0)