Repository navigation
Commit e8a1bd6
committed
BUG: leave the rocket body's stream where it was, and isolate each collection
Moving the body to child zero broke every fixed-seed baseline for mass,
radius and the body inputs, and nothing about the nested-component fix needed
that. The body keeps the seed as given now: stochastic_calisto under seed 42
reads mass=14.906007947 on develop and the same here.
Components were also addressed by one global traversal index, so adding a fin
moved every motor, rail button, parachute and air brake. Each collection has
a root of its own now, spawned from the same seed, so an unrelated component
in one of them leaves the others where they were.
The source scan compares the two sets both ways. A collection left in the
reseed after create_object stops using it still spawns a child and moves
every stream after it, which the subset check let through.
Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>1 parent 7d5b404 commit e8a1bd6
2 files changed
Lines changed: 39 additions & 11 deletions
File tree
- rocketpy/stochastic
- tests/unit/stochastic
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
192 | | - | |
193 | | - | |
194 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
195 | 196 | | |
196 | 197 | | |
197 | 198 | | |
198 | 199 | | |
199 | 200 | | |
200 | 201 | | |
201 | | - | |
202 | | - | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
203 | 205 | | |
204 | | - | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
205 | 209 | | |
206 | 210 | | |
207 | | - | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
208 | 214 | | |
209 | 215 | | |
210 | 216 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
109 | 111 | | |
110 | 112 | | |
111 | 113 | | |
| |||
137 | 139 | | |
138 | 140 | | |
139 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
0 commit comments