Repository navigation
REV: revert #1136, #1129 and #1128 before v1.14.0 - #1210
Merged
Merged
Conversation
Rocket and its prints computed the same factor inline. The test pins that changing a surface's rocket_radius after adding it moves the static margin. Related to #1209 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XDW574AQLHTSeBM9K172TX
Gui-FernandesBR
force-pushed
the
rev/v1.14.0-reverts
branch
from
November 4, 2026 12:44
74a0183 to
c000b6b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1210 +/- ##
===========================================
+ Coverage 91.58% 91.66% +0.08%
===========================================
Files 132 131 -1
Lines 18404 18240 -164
===========================================
- Hits 16855 16720 -135
+ Misses 1549 1520 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1209. Reverts #1136, #1129 and #1128, as agreed in #1194: #1136 has no caller, #1129's stored factor goes stale when a surface's
rocket_radiuschanges afteradd_surfaces(develop: 7.56 cal vs 4.66 for a fresh rocket), and #1128's callback is superseded by #968.The reference-area factor is now computed on demand by
Rocket._reference_area_factor, used by the CP evaluation and the prints, with a test that fails on develop. Issues #561, #660 and #758 are reopened.🤖 Generated with Claude Code
https://claude.ai/code/session_01XDW574AQLHTSeBM9K172TX