[Improve] Align Sessions with Tasks list experience - #1911
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Improve] Align Sessions with Tasks list experience#1911roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| }) { | ||
| const label = formatInferenceCost(costMicroUsd); | ||
|
|
||
| if (Number(label) <= 0) return null; |
Contributor
There was a problem hiding this comment.
This parses a locale-formatted display string to decide visibility. In locales with a comma decimal separator, a sub-cent cost formats as 0,00, Number(label) is NaN, and the check falls through to render it even though it rounds to zero. Check the numeric costMicroUsd (or a numeric USD value) before formatting instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Tasks and Sessions represented the same work-history pattern with separate markup and styling. Sharing the stable presentation boundary keeps the primary Sessions workspace consistent with Tasks without coupling their data or actions.
Impact
Sessions now look and behave like the established Tasks list on desktop and mobile. Domain-specific behavior remains in thin Task and Session adapters, and Session detail panels and shared title utilities are unchanged.
Screenshots