[Improve] Notify users when PR auto-resolve continues - #1947
Draft
roomote-roomote[bot] wants to merge 4 commits into
Draft
[Improve] Notify users when PR auto-resolve continues#1947roomote-roomote[bot] wants to merge 4 commits into
roomote-roomote[bot] wants to merge 4 commits into
Conversation
Contributor
|
No new code issues found. See task
Reviewed 1132329 |
Contributor
Author
|
Fixed both provider-specific findings in 1132329: Slack continuation posts that return no message ID now fail and requeue, while the provider-message checkpoint no longer requires the original lease, allowing Telegram completion retries to skip the already-sent post. Added focused Slack null-result, Telegram completion-retry, and lease-independent database checkpoint coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
When auto-resolve starts work on later PR review feedback, the task now posts the existing "New review feedback - I'm on it" update to its originating communications thread after dispatch succeeds. Canonical delivery checkpoints the provider message before completion, while initial feedback and web-only tasks retain their existing behavior.
Why this change was made
Fast-parent delivery returned before the established communications posting path ran, so users could not see when automatic work continued onto subsequent review feedback. Missing Slack message IDs now trigger retries, and the durable provider-message checkpoint no longer depends on the posting worker retaining its lease.
Impact
Users with a connected task communications channel receive one contextual continuation update identifying the PR feedback being handled. Slack null results remain retryable, while Telegram completion retries skip a continuation message that was already checkpointed.
Validation
pnpm lint