[Fix] Fast sessions stop after interrupted inference retries - #1966
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Fix] Fast sessions stop after interrupted inference retries#1966roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
Contributor
Author
|
Fixed the BullMQ Test timeout and the recovery-context review finding in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Fast already retried transient provider failures in process, but a process exit or lost turn owner converted the durable retry marker into “The inference retry was interrupted before it completed. Please send the request again.” Replaying every marker would be unsafe because a prior attempt may already have executed externally visible tools.
Impact
Users on web, Slack, and Discord no longer need to resend requests when infrastructure interrupts a retry before any tool call. Attempts with uncertain side effects still fail closed, and targeted regression coverage exercises retry eligibility, shutdown handoff, lease-gated queue admission, lock-owned recovery, context replay, and repeated-interruption fallback.