chore(vault): remove vault and btc-vault sections from dApp - #2141
Open
sleyter93 wants to merge 7 commits into
Open
chore(vault): remove vault and btc-vault sections from dApp#2141sleyter93 wants to merge 7 commits into
sleyter93 wants to merge 7 commits into
Conversation
Dependency ReviewThe following issues were found:
|
scguaquetam
approved these changes
May 20, 2026
Member
|
@sleyter93 Please take a look on the next files where Vaults is still being referenced: among other files, there still being used some vaults stuff. |
scguaquetam
requested changes
May 20, 2026
scguaquetam
left a comment
scguaquetam
left a comment
Member
There was a problem hiding this comment.
Check vaults usage in other files
* feat/ adding settings for PostHog tracking * feat/adding capture to prop profile for identifying on posthog which environment is taking the measurement from * feat/adding PostHogWalletSync wrapper for making wallet address a parent property for posthog events * feat/tested-working correctly stake_rif_confirmed and unstake_rif_confirmed events storing information after completing transaction * feat/ adding onError event, for error on staking or unstaking into posthog measurements * feat/ adding POSTHOG doc for clarifying usage, adding event check into allowance process, for error and success * adding Backing activity monitoring, tested and checked on Posthog dashboard * adding collect rewards activity monitoring * adding delegation activity monitoring into Posthog * refactor/ taking out vaults measured events, and refactoring proposal_vote_cast for being measured inside the try-catch function, also adding error event proposal_vote_cast_failed --------- Co-authored-by: scguaquetam <sebastian.guaqueta@rootstocklabs.com>
Deletes all directories exclusively owned by the vault/btc-vault features. Removes vault/rbtcVault/buffer/permissionsManager/syntheticYield from contracts.ts. Removes btc-vault re-export from shared/hooks/contracts/index.ts. Simplifies useFilteredMenuData — role filtering was exclusively for vault nav items. Removes formatApy and ctokenvault from formatter.ts (vault-only dead code).
- menuData.ts: remove getBetaToolsSection functions and RequiredRole type - routes.ts: remove btcVault* route constants - features.conf.ts: remove vault and btc_vault feature definitions - constants.ts: remove vault addresses, roles, and env flag entries - txMessages.ts: remove vault and btc-vault transaction message keys
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Addresses reviewer feedback from scguaquetam:
- .workflow/PROJECT.md, agents/user-story-creator.md, agents/workload-analyst.md
- .workflow/rules/ (architecture-patterns, coding-conventions, documentation-and-testing, git-commits)
- docs/spike-transaction-balance-updates.md, docs/FORK_SETUP.md
- src/app/api/db/constants.ts — removed BTC_VAULT_NAV_HISTORY_COLUMNS and BTC_VAULT_AUDIT_LOG_COLUMNS
- src/components/Breadcrumbs/Breadcrumbs.tsx — removed vault breadcrumb paths
- src/lib/constants.ts, src/lib/endpoints.ts, src/lib/the-graph.ts
- src/lib/contracts.ts — removed vault/rbtcVault/buffer/permissionsManager/syntheticYield exports
- src/lib/abis/VaultAbi.ts, VaultDepositLimiterAbi.ts — deleted
- src/shared/hooks/contracts/btc-vault/ — deleted entire directory
- src/shared/hooks/contracts/index.ts — removed btc-vault re-export
- src/shared/txMessages.ts — removed all vault-related tx messages
- src/shared/components/ApolloClient/makeClient.ts — removed btcVaultClient
- src/shared/constants/routes.ts — removed btcVault route constants
- src/shared/walletConnection/constants.tsx — removed vault route header patterns
- src/components/MainContainer/sidebars/menuData.ts — removed vault menu items and RequiredRole
- src/components/MainContainer/sidebars/useFilteredMenuData.ts — removed role-based filtering
- public/images/sidemenukoto/{BTC-Vault,USD-Vault,FundManager,Admin}.svg — deleted
- Various component JSDoc comments cleaned up
- All .env.* files — removed vault-related env vars
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sleyter93
force-pushed
the
feat/remove-vault
branch
from
June 3, 2026 16:17
d9510b2 to
fa281ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/app/vault/,src/app/btc-vault/,src/app/api/vault/,src/app/api/btc-vault/,src/app/fund-manager/,src/app/fund-admin/contracts.tsexports,formatter.tsvault utilitiesTest plan