Repository navigation
P4c: build hygiene and deferred cleanup - #1
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- CMakePresets.json with default/asan configure presets, debug/release/asan build and test presets, and a ci workflow preset. - /W4 /permissive- plus the cpp-best-practices warning set as errors on our targets; third_party is a SYSTEM include (/external:W0). The code was already clean. - gao.exe: /guard:cf /sdl, linked /GUARD:CF /CETCOMPAT (verified with dumpbin). - Embedded manifest: asInvoker, Windows 10/11, longPathAware, UTF-8 code page, PerMonitorV2; the console output code page is set to UTF-8. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…op when a journal close fails - Journal lines with an id outside 1..999999999 or a clock value outside 0..100000 are ignored, and integers are range-checked before narrowing (4294967305 no longer truncates to 9). - A boot_strikes value that is present but not a whole number in 0..1000 reads as the maximum: boot-apply fails closed instead of re-enabling. - A journal entry that cannot be closed stops the run at stock. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- --stress drops the errors= column (a wrong value ends the run before a line prints) and prints n/a instead of -1 in the verdict. - --optimize refuses to tune when its journal exists but cannot be read, or cannot be written (a session line is written first). - --optimize never saves a profile without a driver version and GPU id, and a new profile starts with zero strikes. - An unknown driver at logon gets its own message instead of 'driver changed'. - --reset reports when the power limit could not be restored. - The power-range callback no longer dereferences a failed query. - A failed atomic write removes its temp file. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… ASan Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
/guard:cf only guards code compiled with it, so the NVAPI function-pointer calls in hw/ were unchecked. A gao_hardening interface now applies /guard:cf /sdl to core, hw and gao (clean build). Also from the review: presets require CMake 4.2 (the VS 2026 generator), test presets fail when no test is found, read_lines reports a read error mid-file, and the strike test asserts the exact fail-closed value. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress (overnight session). Opened as a draft so CI runs on the branch, including the new ASan job.
🤖 Generated with Claude Code