Skip to content

Commit bc86ad1

Browse files
authored
chore: upgrade to Expo SDK 56, fix typecheck, add CI (#14)
Bump expo to ^56 and align react-native, react, react-dom, and the Expo managed deps to the SDK 56 compatible versions. Config migration: remove newArchEnabled (new architecture is now the default) and android.edgeToEdgeEnabled (dropped in SDK 56) from app.json and app.config.ts, and move the top-level splash config into the expo-splash-screen plugin. Typecheck: add a tsconfig exclude for test files and declare the css module so the global.css import resolves. Add ci.yml gate running tsc and the test suite on push and pull request.
1 parent 9101749 commit bc86ad1

7 files changed

Lines changed: 2132 additions & 2060 deletions

File tree

.github/workflows/ci.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: CI
2+
3+
on:
4+
push:
5+
branches: [main]
6+
pull_request:
7+
8+
jobs:
9+
verify:
10+
runs-on: ubuntu-latest
11+
steps:
12+
- uses: actions/checkout@v4
13+
- uses: actions/setup-node@v4
14+
with:
15+
node-version: 20
16+
cache: npm
17+
- run: npm ci
18+
- run: npx tsc --noEmit
19+
- run: npm test

app.config.ts

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,7 @@ export default ({ config }: ConfigContext): ExpoConfig => ({
88
orientation: "portrait",
99
icon: "./assets/icon.png",
1010
userInterfaceStyle: "automatic",
11-
newArchEnabled: true,
1211
scheme: "roxyapi-numerology",
13-
splash: {
14-
image: "./assets/splash-icon.png",
15-
resizeMode: "contain",
16-
backgroundColor: "#ffffff",
17-
},
1812
ios: {
1913
supportsTablet: true,
2014
bundleIdentifier: "com.roxyapi.numerology",
@@ -25,13 +19,22 @@ export default ({ config }: ConfigContext): ExpoConfig => ({
2519
backgroundColor: "#ffffff",
2620
},
2721
package: "com.roxyapi.numerology",
28-
edgeToEdgeEnabled: true,
2922
predictiveBackGestureEnabled: false,
3023
},
3124
web: {
3225
favicon: "./assets/favicon.png",
3326
},
34-
plugins: ["expo-router"],
27+
plugins: [
28+
"expo-router",
29+
[
30+
"expo-splash-screen",
31+
{
32+
image: "./assets/splash-icon.png",
33+
resizeMode: "contain",
34+
backgroundColor: "#ffffff",
35+
},
36+
],
37+
],
3538
experiments: {
3639
typedRoutes: true,
3740
},

app.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
"orientation": "portrait",
77
"icon": "./assets/icon.png",
88
"userInterfaceStyle": "light",
9-
"newArchEnabled": true,
10-
"splash": {
11-
"image": "./assets/splash-icon.png",
12-
"resizeMode": "contain",
13-
"backgroundColor": "#ffffff"
14-
},
159
"ios": {
1610
"supportsTablet": true
1711
},
@@ -20,7 +14,6 @@
2014
"foregroundImage": "./assets/adaptive-icon.png",
2115
"backgroundColor": "#ffffff"
2216
},
23-
"edgeToEdgeEnabled": true,
2417
"predictiveBackGestureEnabled": false
2518
},
2619
"web": {

nativewind-env.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
/// <reference types="nativewind/types" />
2+
3+
declare module "*.css";

0 commit comments

Comments
 (0)