fix(dasha-timeline): derive the heading from the payload so attribute-less hosts read correctly

Author: ph33nx

packages/ui/src/components/dasha-timeline.ts

@@ -239,7 +239,8 @@ export class RoxyDashaTimeline extends RoxyDataElement<DashaData> {
 	 * Which dasha endpoint fed this element. `sub`, `antara` and `sookshma` are the
 	 * three drill-down levels and render identically; they stay distinct because
 	 * each maps one-to-one onto its endpoint binding, which is what lets a widget
-	 * pick a level. The LABELS come from the payload, not from here.
+	 * pick a level. The heading and the level LABELS come from the payload, not
+	 * from here, so a host that cannot set attributes still renders correctly.
 	 */
 	@property({ type: String, reflect: true })
 	period: 'current' | 'major' | 'sub' | 'antara' | 'sookshma' = 'current';
@@ -248,11 +249,6 @@ export class RoxyDashaTimeline extends RoxyDataElement<DashaData> {
 	@state()
 	private view: 'timeline' | 'readings' | 'frame' = 'timeline';
 
-	/** True for any of the drill-down levels, which share one layout. */
-	private get isDrillDown(): boolean {
-		return this.period !== 'current' && this.period !== 'major';
-	}
-
 	protected renderEmpty() {
 		return html`<div class="roxy-empty" role="status">No dasha data</div>`;
 	}
@@ -412,16 +408,25 @@ export class RoxyDashaTimeline extends RoxyDataElement<DashaData> {
 		</dl>`;
 	}
 
+	/**
+	 * Heading, decided by the PAYLOAD first and the `period` attribute only as a
+	 * tie-break.
+	 *
+	 * Not every host can set the attribute. The WordPress plugin maps an
+	 * operationId to a bare component tag with no attrs, so every dasha shortcode
+	 * arrives with the default `period="current"`; keying off the attribute alone
+	 * titled an antardasha list "Active dashas" there. A drill-down response is
+	 * self-identifying (it carries a parent period), so the markup does not need
+	 * to be told.
+	 */
 	private heading(d: DashaData): string {
-		if (this.period === 'major') return 'Vimshottari Mahadasha';
-		if (this.isDrillDown) {
-			const parent = parentOf(d);
-			const level = levelOf(d);
-			return parent
-				? `${level}s in ${parent.period.planet} ${parent.label}`
-				: `${level}s`;
+		const parent = parentOf(d);
+		if (parent) {
+			return `${levelOf(d)}s in ${parent.period.planet} ${parent.label}`;
 		}
-		return 'Active dashas';
+		if ('mahadashas' in d) return 'Vimshottari Mahadasha';
+		if ('mahadasha' in d) return 'Active dashas';
+		return this.period === 'major' ? 'Vimshottari Mahadasha' : 'Active dashas';
 	}
 
 	/**

packages/ui/tests/components.test.ts

@@ -2094,3 +2094,65 @@ describe('roxy-dasha-timeline date column adapts to the period length', () => {
 		el.remove();
 	});
 });
+
+/**
+ * A host that cannot pass attributes must still get correct headings. The
+ * WordPress plugin maps an operationId to a bare tag with no attrs, so every
+ * dasha shortcode arrives with the default `period="current"`; the heading has to
+ * come from the payload or an antardasha list is titled "Active dashas" there.
+ */
+describe('roxy-dasha-timeline heads correctly with no period attribute', () => {
+	async function mountNoAttrs(data: unknown) {
+		const el = document.createElement('roxy-dasha-timeline') as HTMLElement & {
+			data?: unknown;
+		};
+		document.body.appendChild(el);
+		el.data = data;
+		await settled(el);
+		return el;
+	}
+	const heading = (el: Element) =>
+		el.shadowRoot?.querySelector('.title')?.textContent?.trim() ?? '';
+
+	test('a drill-down payload titles itself, not "Active dashas"', async () => {
+		const el = await mountNoAttrs({
+			mahadashaLord: 'Saturn',
+			antardashaLord: 'Venus',
+			antardashaPeriod: { planet: 'Venus', durationYears: 3.2 },
+			pratyantardashas: [
+				{
+					planet: 'Venus',
+					startDate: '2025-06-20T00:00:00',
+					endDate: '2025-12-29T00:00:00',
+					durationYears: 0.5,
+				},
+			],
+		});
+		expect(heading(el)).toBe('Pratyantardashas in Venus Antardasha');
+		el.remove();
+	});
+
+	test('a major payload titles itself', async () => {
+		const el = await mountNoAttrs({
+			mahadashas: [
+				{
+					planet: 'Ketu',
+					startDate: '1990-01-15T00:00:00',
+					endDate: '1997-01-15T00:00:00',
+					durationYears: 7,
+				},
+			],
+		});
+		expect(heading(el)).toBe('Vimshottari Mahadasha');
+		el.remove();
+	});
+
+	test('a current payload still reads as the running periods', async () => {
+		const el = await mountNoAttrs({
+			mahadasha: { planet: 'Saturn' },
+			antardasha: { planet: 'Venus' },
+		});
+		expect(heading(el)).toBe('Active dashas');
+		el.remove();
+	});
+});