Skip to content

Commit f8b3971

Browse files
ph33nxph33nx
committed
refactor(i18n): one key per concept, and drop what nothing reaches
Audit of the changeset: - Aspect patterns beside Chart patterns, and Birthplace beside Birth location, were each one concept catalogued twice across two components. Neither the cross-component check nor the fold check can see it once both sit inside t(), because both look at spelling rather than meaning - the accordion heading default was unreachable: its one caller always resolves the heading first - the three wire identifiers left the markup when that notice became two whole sentences, so their exemptions no longer guard anything
1 parent ad4a07d commit f8b3971

12 files changed

Lines changed: 4 additions & 24 deletions

File tree

‎packages/ui/src/components/aspects-table.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ export class RoxyAspectsTable extends RoxyDataElement<AspectsData> {
285285

286286
return html`<div class="wrap" part="card" aria-label=${this.t('Aspects')}>
287287
<div class="head" part="header">
288-
<h2 class="title">${aspects.length === 0 ? this.t('Aspect patterns') : this.t('Aspects')}</h2>
288+
<h2 class="title">${aspects.length === 0 ? this.t('Chart patterns') : this.t('Aspects')}</h2>
289289
${
290290
aspects.length > 0 || date
291291
? html`<p class="subtitle">

‎packages/ui/src/components/astrocartography-map.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ export class RoxyAstrocartographyMap extends RoxyDataElement<AstrocartographyRes
253253
${lines.map((l, i) => this.renderBodyLines(l, i))}
254254
${
255255
bd
256-
? svg`<text class="birthplace" x=${lonToX(bd.longitude)} y=${latToY(bd.latitude)} text-anchor="middle" dominant-baseline="central"><title>${this.t('Birthplace')}</title>★</text>`
256+
? svg`<text class="birthplace" x=${lonToX(bd.longitude)} y=${latToY(bd.latitude)} text-anchor="middle" dominant-baseline="central"><title>${this.t('Birth location')}</title>★</text>`
257257
: nothing
258258
}
259259
</svg>`;

‎packages/ui/src/i18n/chrome-strings.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,6 @@ export const CHROME_STRINGS = [
654654
'Astrocartography world map',
655655
'World map of planetary astrocartography lines',
656656
'Equirectangular world map. Each body has a Midheaven and Imum Coeli meridian and a curved Ascendant and Descendant line, colored per body.',
657-
'Birthplace',
658657
'{{planet}} {{angle}} line',
659658
'Solid lines are the Ascendant and Midheaven, dashed are the Descendant and IC.',
660659
'Planetary lines',
@@ -739,7 +738,6 @@ export const CHROME_STRINGS = [
739738

740739
// Two-state labels chosen by a ternary, and the aspect card heading beside
741740
// them. Both branches are copy, so both are catalogued.
742-
'Aspect patterns',
743741
'Above',
744742
'Below',
745743
'Active',

‎packages/ui/src/locales/de.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,6 @@ export const de: Record<ChromeString, string> = {
576576
'Weltkarte der planetaren Astrokartografie-Linien',
577577
'Equirectangular world map. Each body has a Midheaven and Imum Coeli meridian and a curved Ascendant and Descendant line, colored per body.':
578578
'Plattkarte der Welt. Jeder Himmelskörper hat einen Meridian für Himmelsmitte und Himmelstiefe sowie eine gebogene Aszendenten- und Deszendentenlinie, je Körper eingefärbt.',
579-
Birthplace: 'Geburtsort',
580579
'{{planet}} {{angle}} line': '{{planet}}-{{angle}}-Linie',
581580
'Solid lines are the Ascendant and Midheaven, dashed are the Descendant and IC.':
582581
'Durchgezogene Linien sind Aszendent und Himmelsmitte, gestrichelte sind Deszendent und Himmelstiefe.',
@@ -651,7 +650,6 @@ export const de: Record<ChromeString, string> = {
651650
'What to do next': 'Was als Nächstes zu tun ist',
652651
'Foundational digit root': 'Grundlegende Quersumme',
653652
'Foundational digit root ({{n}})': 'Grundlegende Quersumme ({{n}})',
654-
'Aspect patterns': 'Aspektfiguren',
655653
Above: 'Über dem Horizont',
656654
Below: 'Unter dem Horizont',
657655
Active: 'Aktiv',

‎packages/ui/src/locales/es.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,6 @@ export const es: Record<ChromeString, string> = {
588588
'Mapamundi de las líneas planetarias de astrocartografía',
589589
'Equirectangular world map. Each body has a Midheaven and Imum Coeli meridian and a curved Ascendant and Descendant line, colored per body.':
590590
'Mapamundi equirrectangular. Cada cuerpo tiene un meridiano de Mediocielo y Fondocielo y una línea curva de Ascendente y Descendente, coloreada por cuerpo.',
591-
Birthplace: 'Lugar de nacimiento',
592591
'{{planet}} {{angle}} line': 'Línea {{angle}} de {{planet}}',
593592
'Solid lines are the Ascendant and Midheaven, dashed are the Descendant and IC.':
594593
'Las líneas continuas son el Ascendente y el Mediocielo, las discontinuas el Descendente y el Fondocielo.',
@@ -663,7 +662,6 @@ export const es: Record<ChromeString, string> = {
663662
'What to do next': 'Qué hacer ahora',
664663
'Foundational digit root': 'Raíz digital de base',
665664
'Foundational digit root ({{n}})': 'Raíz digital de base ({{n}})',
666-
'Aspect patterns': 'Figuras de aspectos',
667665
Above: 'Sobre el horizonte',
668666
Below: 'Bajo el horizonte',
669667
Active: 'Activo',

‎packages/ui/src/locales/fr.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,6 @@ export const fr: Record<ChromeString, string> = {
581581
'Carte du monde des lignes planétaires en astrocartographie',
582582
'Equirectangular world map. Each body has a Midheaven and Imum Coeli meridian and a curved Ascendant and Descendant line, colored per body.':
583583
'Carte du monde équirectangulaire. Chaque corps a un méridien de Milieu du Ciel et de Fond du Ciel, plus une ligne courbe Ascendant et Descendant, colorée par corps.',
584-
Birthplace: 'Lieu de naissance',
585584
'{{planet}} {{angle}} line': 'Ligne {{angle}} de {{planet}}',
586585
'Solid lines are the Ascendant and Midheaven, dashed are the Descendant and IC.':
587586
'Les lignes pleines marquent Ascendant et Milieu du Ciel, les pointillées Descendant et Fond du Ciel.',
@@ -656,7 +655,6 @@ export const fr: Record<ChromeString, string> = {
656655
'What to do next': 'Que faire ensuite',
657656
'Foundational digit root': 'Racine numérique de base',
658657
'Foundational digit root ({{n}})': 'Racine numérique de base ({{n}})',
659-
'Aspect patterns': 'Figures planétaires',
660658
Above: 'Au-dessus',
661659
Below: 'Au-dessous',
662660
Active: 'Actif',

‎packages/ui/src/locales/hi.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,6 @@ export const hi: Record<ChromeString, string> = {
589589
'ग्रह ज्योतिष रेखाओं का विश्व मानचित्र',
590590
'Equirectangular world map. Each body has a Midheaven and Imum Coeli meridian and a curved Ascendant and Descendant line, colored per body.':
591591
'समआयत विश्व मानचित्र। प्रत्येक पिंड की मध्य आकाश और पाताल याम्योत्तर तथा वक्र लग्न और अस्त रेखा है, पिंड अनुसार रंगीन।',
592-
Birthplace: 'जन्म स्थान',
593592
'{{planet}} {{angle}} line': '{{planet}} {{angle}} रेखा',
594593
'Solid lines are the Ascendant and Midheaven, dashed are the Descendant and IC.':
595594
'ठोस रेखाएँ लग्न और मध्य आकाश हैं, बिंदुदार अस्त और पाताल हैं।',
@@ -662,7 +661,6 @@ export const hi: Record<ChromeString, string> = {
662661
'What to do next': 'आगे क्या करें',
663662
'Foundational digit root': 'आधारभूत अंक मूल',
664663
'Foundational digit root ({{n}})': 'आधारभूत अंक मूल ({{n}})',
665-
'Aspect patterns': 'दृष्टि विन्यास',
666664
Above: 'क्षितिज के ऊपर',
667665
Below: 'क्षितिज के नीचे',
668666
Active: 'सक्रिय',

‎packages/ui/src/locales/pt.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,6 @@ export const pt: Record<ChromeString, string> = {
568568
'Mapa-múndi das linhas planetárias de astrocartografia',
569569
'Equirectangular world map. Each body has a Midheaven and Imum Coeli meridian and a curved Ascendant and Descendant line, colored per body.':
570570
'Mapa-múndi equirretangular. Cada corpo tem um meridiano de Meio do Céu e Fundo do Céu e uma linha curva de Ascendente e Descendente, colorida por corpo.',
571-
Birthplace: 'Local de nascimento',
572571
'{{planet}} {{angle}} line': 'Linha {{angle}} de {{planet}}',
573572
'Solid lines are the Ascendant and Midheaven, dashed are the Descendant and IC.':
574573
'As linhas contínuas são o Ascendente e o Meio do Céu, as tracejadas o Descendente e o Fundo do Céu.',
@@ -643,7 +642,6 @@ export const pt: Record<ChromeString, string> = {
643642
'What to do next': 'O que fazer a seguir',
644643
'Foundational digit root': 'Raiz digital de base',
645644
'Foundational digit root ({{n}})': 'Raiz digital de base ({{n}})',
646-
'Aspect patterns': 'Figuras de aspectos',
647645
Above: 'Acima',
648646
Below: 'Abaixo',
649647
Active: 'Ativo',

‎packages/ui/src/locales/ru.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,6 @@ export const ru: Record<ChromeString, string> = {
569569
'Мировая карта планетных линий астрокартографии',
570570
'Equirectangular world map. Each body has a Midheaven and Imum Coeli meridian and a curved Ascendant and Descendant line, colored per body.':
571571
'Равнопромежуточная мировая карта. У каждого тела есть меридиан Середины неба и Глубины неба и изогнутая линия Асцендента и Десцендента, окрашенная по телу.',
572-
Birthplace: 'Место рождения',
573572
'{{planet}} {{angle}} line': 'Линия {{angle}} для {{planet}}',
574573
'Solid lines are the Ascendant and Midheaven, dashed are the Descendant and IC.':
575574
'Сплошные линии это Асцендент и Середина неба, пунктирные Десцендент и Глубина неба.',
@@ -643,7 +642,6 @@ export const ru: Record<ChromeString, string> = {
643642
'What to do next': 'Что делать дальше',
644643
'Foundational digit root': 'Базовый цифровой корень',
645644
'Foundational digit root ({{n}})': 'Базовый цифровой корень ({{n}})',
646-
'Aspect patterns': 'Аспектные конфигурации',
647645
Above: 'Над горизонтом',
648646
Below: 'Под горизонтом',
649647
Active: 'Активен',

‎packages/ui/src/locales/tr.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,6 @@ export const tr: Record<ChromeString, string> = {
575575
'Gezegen astrokartografi hatlarının dünya haritası',
576576
'Equirectangular world map. Each body has a Midheaven and Imum Coeli meridian and a curved Ascendant and Descendant line, colored per body.':
577577
'Eşdikdörtgen dünya haritası. Her gök cisminin bir Gökyüzü ortası ve Ayakucu meridyeni ile eğri bir Yükselen ve Alçalan hattı vardır, cisme göre renklendirilir.',
578-
Birthplace: 'Doğum yeri',
579578
'{{planet}} {{angle}} line': '{{planet}} {{angle}} hattı',
580579
'Solid lines are the Ascendant and Midheaven, dashed are the Descendant and IC.':
581580
'Düz çizgiler Yükselen ve Gökyüzü ortası, kesikli olanlar Alçalan ve Ayakucudur.',
@@ -650,7 +649,6 @@ export const tr: Record<ChromeString, string> = {
650649
'What to do next': 'Sırada ne var',
651650
'Foundational digit root': 'Temel basamak kökü',
652651
'Foundational digit root ({{n}})': 'Temel basamak kökü ({{n}})',
653-
'Aspect patterns': 'Açı desenleri',
654652
Above: 'Ufkun üstünde',
655653
Below: 'Ufkun altında',
656654
Active: 'Etkin',

0 commit comments

Comments
 (0)