test: guard the fake --output lookup in report tests - #8
Merged
Merged
Conversation
Two fake spawns indexed args[indexOf("--output") + 1] without checking
for -1, so a fallow invocation resolved to args[0] and the test wrote a
stray dupes/index.html into the working directory. Shared helper
writeHtmlOutput replaces the four copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fake spawns in
tests/report/advisory.test.tsindexedargs[indexOf("--output") + 1]without checking for-1. For fallow invocations that resolved toargs[0], so running the suite wrote a straydupes/index.htmlinto the working directory. A sharedwriteHtmlOutputhelper replaces the four copies of that block.Verification