skein: fix AlgorithmName implementations (#930)

Author: zoupingcenter

skein/CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.2.1 (UNRELEASED)
+### Fixed
+- `AlgorithmName` implementations
+
 ## 0.2.0 (2026-04-10)
 ### Added
 - `alloc` crate feature ([#678])

skein/src/block_api.rs

@@ -24,7 +24,7 @@ const CFG_STR_LEN: usize = 4 * 8;
 
 macro_rules! define_hasher {
     (
-        $name:ident, $threefish:ident,
+        $name:ident, $full_name:ident, $threefish:ident,
         $state_bytes:ty, $alg_name:expr
     ) => {
         #[doc = $alg_name]
@@ -209,6 +209,6 @@ macro_rules! define_hasher {
     };
 }
 
-define_hasher!(Skein256Core, Threefish256, U32, "Skein-256");
-define_hasher!(Skein512Core, Threefish512, U64, "Skein-512");
-define_hasher!(Skein1024Core, Threefish1024, U128, "Skein-1024");
+define_hasher!(Skein256Core, Skein256, Threefish256, U32, "Skein-256");
+define_hasher!(Skein512Core, Skein512, Threefish512, U64, "Skein-512");
+define_hasher!(Skein1024Core, Skein1024, Threefish1024, U128, "Skein-1024");

skein/tests/mod.rs

@@ -12,6 +12,35 @@ hash_serialization_test!(skein256_serialization, skein::Skein256_256);
 hash_serialization_test!(skein512_serialization, skein::Skein512_512);
 hash_serialization_test!(skein1024_serialization, skein::Skein1024_1024);
 
+#[test]
+fn algorithm_names() {
+    use core::{fmt, marker::PhantomData};
+    use skein::digest::{block_api::AlgorithmName, consts::U7};
+
+    struct Name<T>(PhantomData<T>);
+
+    impl<T: AlgorithmName> fmt::Display for Name<T> {
+        fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+            T::write_alg_name(f)
+        }
+    }
+
+    fn assert_name<T: AlgorithmName>(expected: &str) {
+        assert_eq!(format!("{}", Name::<T>(PhantomData)), expected);
+    }
+
+    assert_name::<skein::Skein256_256>("Skein256");
+    assert_name::<skein::Skein256_512>("Skein256");
+    assert_name::<skein::Skein512_256>("Skein512");
+    assert_name::<skein::Skein512_512>("Skein512");
+    assert_name::<skein::Skein1024_256>("Skein1024");
+    assert_name::<skein::Skein1024_512>("Skein1024");
+    assert_name::<skein::Skein1024_1024>("Skein1024");
+    assert_name::<skein::Skein256<U7>>("Skein256");
+    assert_name::<skein::Skein512<U7>>("Skein512");
+    assert_name::<skein::Skein1024<U7>>("Skein1024");
+}
+
 /// Regression tests for https://github.com/RustCrypto/hashes/issues/681
 #[test]
 fn skein_uncommon_sizes() {