Repository navigation
test(statics): gate the low-EI sweep cases on the deck route - #108
Merged
Merged
Conversation
static_init_sweep runs the mesh-sequenced kernel from the trivial seed. Four of its low-EI lazy waves (EI 5e2 N m2) reach a residual-converged kink of a few elements in mid-water there, which the h*kappa check rejects; the 800 m EA = 5e7 N case it also listed now passes on every OpenBLAS kernel. A deck never takes that combination for a line with a buoyant section: it seeds the line as a lazy wave, starts from the EI = 0 catenary and refines a kinked state locally. Run through the driver, the deck route solves all 121 well-posed sweep cases on both cable_statics routes (agreeing to 1.3e-7 in tension, max h*kappa 0.56) and refuses the one beyond the L-shape bound by name. - cable_statics_matrix: the five low-EI cases on both routes (SIS_*), with an independent elastic multi-segment EI = 0 catenary as the fairlead oracle where the arch stays submerged (within 2.4e-4). - static_init_sweep: the passing case leaves the known-fail list; the header states what the list means and that an unexpected pass is reported, not failed. - VALIDATION.md: the counts (118 pass, 4 known failures, not 117/3/2) and the deck-route result. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static_init_sweepruns the mesh-sequenced kernel from the trivial seed. Four of its low-EI lazy waves (EI 5e2 N·m²) reach a residual-converged kink of a few elements in mid-water, which theh*kappacheck rejects. The fifth case on its known-fail list (800 m, EA 5e7 N) now passes on every OpenBLAS kernel (default, Prescott, Nehalem, Sandybridge, Haswell, Zen).A deck never takes that combination for a line with a buoyant section. It seeds the line as a lazy wave, starts from the EI = 0 catenary, and refines a kinked state locally. I ran all 122 sweep cases through the standalone driver on both
cable_staticsroutes:max(h*kappa)Changes
cable_statics_matrix: the five low-EI cases on both routes (SIS_*). The fairlead oracle is an independent elastic multi-segment EI = 0 catenary, with constant H, buoyant sections and a frictionless grounded tail. Where the arch stays submerged, CableDyn is within 2.4e-4 of it. Two cases float their arch at the surface, so they carry no submerged oracle.static_init_sweep: the passing case leaves the known-fail list. The header now says what the list means, and that an unexpected pass is reported, not failed (the code already did that).No solver change; all outputs are unchanged.
Tests
static_init_sweep,cable_statics_matrix(133/133),documentation_sourcesandvalidation_recordspass on a Release build with no warnings.