Repository navigation
fix(recovery): spread the touchdown node's floor reaction over its grounded stretch - #109
Merged
Merged
Conversation
…ounded stretch The equilibrium recovery of the finite-EI node outputs spreads each nodal seabed reaction over the grounded half-elements beside the node. The touchdown element, on the floor at one end only, took none of the first grounded node's reaction, wherever the touchdown point lay in it. The node tension next to touchdown then carried a local error that depended on that position and fell only at the first order with the element length: at most 4.3, 1.9, 1.0 and 0.42 N at 1.6, 0.8, 0.4 and 0.2 m elements on a lazy-wave cable at 270 N. The share also switched when a node grounded, so the node outputs stepped by up to about 1 N in a quasi-static march as the touchdown point crossed a node. The touchdown element is now grounded from its grounded node to the touchdown point, where the clearance interpolated linearly between its two nodes reaches the contact onset height (at most its half), and takes the reaction of that stretch: a node's reaction is spread uniformly over the grounded part of its two half-elements and shared by that length. The stretch reaches the half-element as the suspended node reaches the floor and vanishes with the reaction as the grounded node lifts off, so the outputs vary continuously. The local error now falls at the second order (2.1, 0.7, 0.2, 0.05 N). The solution, the end forces and the touchdown channels are unchanged. driver_touchdown_convergence sweeps nine meshes at each of three element sizes so that the touchdown point falls at every position in its element, and requires the local error to fall by at least 2.5 from 0.8 to 0.4 m elements and to stay below 0.35 N there; it fails on the previous recovery (ratio 1.89, 1.0 N). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node tension recovered at the touchdown node of a finite-EI cable (the default
OutputRecovery equilibrium) had a local error that fell only at first order with the element length. The size of the error depended on where the touchdown point lay in its element. It also stepped when a node grounded or lifted off.Cause
The equilibrium recovery spreads each nodal seabed reaction over the grounded half-elements beside the node. The touchdown element, which is on the floor at one end only, took none of the first grounded node's reaction, wherever the touchdown point was.
Fix
This is an output-recovery change only. The solution, end forces and touchdown channels are unchanged.
Evidence
Worst local tension error over all touchdown positions, lazy wave in current at 270 N:
OutputRecovery element: left as it is. It is the legacy pointwise definition, with documented oscillation.doc/outputs.rst).Changed outputs
.outtime series: every one of the 61 example decks gives bit-identical.outtime series..static.out/.range.out: only the touchdown-node values change. Tension moves by at most 0.44 N; bend moment at the first grounded node moves by up to 17 N·m on the 3.3 m mesh oflozon_gomex80_power_cable_motion.dat, where both the old and new values are unresolved.Tests
driver_touchdown_convergence: it uses nine meshes at each of 1.6 / 0.8 / 0.4 m against a 2048-element reference. It requires the error to fall by at least 2.5× from 0.8 to 0.4 m and to stay below 0.35 N.OPENBLAS_CORETYPE=Prescott.