Repository navigation
fix(statics): smear the attachment drag in a cross current - #110
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The static solve of a finite-EI line with ATTACHMENTS finds the equilibrium with each attachment's net weight smeared over the elements beside its node, then moves the loads to the node in the attachment polish. The smeared start carried the weight but not the attachments' current drag, so the polish applied the whole drag to a state without it. In a current across the line's vertical plane that drag pushes the line out of the plane; on a frictional seabed the grounded run slid metres sideways and the damped Newton solves diverged from the first load step, so the discrete state was reached only through the pseudo-transient and line-search fallbacks, or not at all (a lazy wave with 25 modules on 2 m elements in 0.3 m/s across its plane; 89 of 234 variants of the frictional lazy wave over current speed, heading, module count and mesh refinement fell back, and a lazy wave restrained in torsion in 0.3 m/s at 45 deg stopped). In a current across the plane the attachments' drag areas are now smeared over the same elements as their weight (per-metre drag coefficients of those elements), and the polish moves the smeared drag to the nodes with the weight. Its load steps then move the line by millimetres and converge in a few Newton iterations; refined reference meshes give the same equilibrium to the printed digits. A current along the plane keeps the former path, which the polish handles without fallbacks, and every in-plane or still-water deck is bit-identical. A new test, attachment_polish_current, sweeps speed, heading, module count and refinement on the frictional lazy wave (no fallback note, deflection toward the current), solves the lazy wave restrained in torsion at 45 deg, and checks the global force balance of a mid-water lazy wave through the C API. attachment_cross_current now requires the refined deck to converge without its fallbacks. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
f027e3b to
52bd7d4
Compare
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
In a current across its plane, on a frictional seabed, the static solve of a finite-EI line with ATTACHMENTS reached the discrete attachment state only through the polish fallbacks (pseudo-transient continuation, line search, halved steps), and in some cases failed. One example is a lazy wave with 25 modules in 0.3 m/s across its plane: its first polish step stalled at load fraction 0.125 after 200 Newton iterations.
Cause
Fix
smear_attachment_drag: in a current with a component across the chord's vertical plane, the attachments' CdA and CdAx are added to the elements' drag coefficients, using the line's own Morison law and the same split as the weight.attachment_static_polishblends those coefficients back to the bare ones with the load fraction, as it does the weights.Evidence
The sweep covers 351 decks: speed 0–0.5 m/s × heading 0/45/90° × 10/25/40 modules × 1/2/4× refinement, over three deck families.
lazy_wave_buoyancy_modules.dat(frictionless)examples/*.datare byte-identical in every result file.Tests
attachment_polish_current: 16 frictional decks plus the torsion deck at 45°, all requiring no fallback note, and 4 force-balance checks.attachment_cross_current: now requires no fallback on any case. Previously it required the fallback note.