Repository navigation
fix(viv): MoorDyn's lift direction on either deck order; VIVphaseSeed - #111
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0fa0233dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
MoorDyn takes the node tangent of the synchronisation model from End A to End B and starts node i from End A at 2 pi i/N. CableDyn's model numbers its nodes from End B, so on a line the reader keeps in the deck order (written fairlead first) its tangent ran from End B to End A. That turns the lift and the cross-flow axis around, which is MoorDyn's model started from the phases plus pi: the t = 0 lift 2 m from End A was -4.68 N where MoorDyn's is +4.66 N, on every route (single line, multibody march, mixed aggregate, refined mesh). The seed now adds that half turn where the model's tangent runs against MoorDyn's (CD_Deck_VIV_Phase_Seed, which the deck driver now passes on every line), so the lift field and the V line files are MoorDyn's whichever end the deck writes first. The taut line of viv_lockin locks into different modes in CableDyn and MoorDyn-F between about 0.21 and 0.33 m/s. Two lock-in branches coexist there: a line locked in mode 1 at 0.18 m/s stays in mode 1 as the current rises (A/D 0.710/0.701/0.686/0.671/0.662 at 0.21-0.33 m/s, MoorDyn-F's 0.709/0.699/0.685/0.670/0.659), one coming down from 0.30 m/s stays in mode 2. From rest CableDyn settles in mode 2, as MoorDyn-C v2.7.2 does (U 0.24 m/s: A/D 0.575 against 0.574 at x/L 0.24, the same frequency). MoorDyn-F v2.3.8 (OpenFAST v5.0.0) sets the seed in Line%phi but never copies it into the state vector it integrates, so its phases start at zero: a uniform lift that excites the symmetric modes only. With every phase at zero CableDyn follows MoorDyn-F's transient to four digits over 12 s and its mode-1 branch over the whole band. The new OPTION VIVphaseSeed (spread, the default; zero) selects that start; the Python deck validator mirrors it. viv_lockin gains the band at U 0.24 m/s against MoorDyn-C (spread) and MoorDyn-F (zero) and the t = 0 lift on both deck orders, EI = 0 and finite EI; viv_coupled and hermite_viv check the new seeds. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…'s frame The phase rate falls back to phi_y = 0 at a node with no cross-flow motion (a node at rest, a held end of a finite-EI cable, whose phase feeds the lift of its elements). On a line whose node tangent runs against MoorDyn's, the seed is MoorDyn's plus pi because turning the tangent around turns the cross-flow axis and so phi_y by half a turn; the fallback has to turn with it, or the synchronisation term changes sign there. It now takes pi on such a line (CD_VIV_Phase_Rate phi_rest, set by the VIV setters from tangent_reversed, which the deck driver passes as the line's orientation). On the viv_lockin line at U 0.24 m/s the finite-EI cable written fairlead first and anchor first drifted 2.3e-4 m apart at mid span within 60 s (1.4 % of the amplitude); the two now give the same response to the printed digits, and viv_lockin gates that on both line kinds. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
da9c7a4 to
62b1a59
Compare
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This closes the VIV mode disagreement that VALIDATION.md recorded as "Pass scoped": between 0.21 and 0.33 m/s the taut line of
viv_lockinsettled on mode 2 in CableDyn and on mode 1 in MoorDyn-F. It also fixes a real parity defect found on the way.Fix: the lift direction on fairlead-first decks
MoorDyn takes the node tangent from End A to End B, and seeds node i from End A at 2πi/N. CableDyn's model numbers its nodes from End B. On a line kept in the deck order, so the tangent ran B→A, which flips both the lift and the cross-flow axis. That is MoorDyn's model started from its phases plus π.
The t = 0 lift 2 m from End A was −4.68 N, where MoorDyn's is +4.66 N. This held on every route: single line, multibody march, mixed aggregate, refined mesh.
CD_Deck_VIV_Phase_Seednow adds the half turn where the tangents disagree, and the deck driver passes it on every line. The lift field and theVline files are now MoorDyn's on either deck order.The band: two coexisting branches, and a MoorDyn-F seed defect
Hysteresis. A line locked in mode 1 at 0.18 m/s and ramped up stays in mode 1. One ramped down from 0.30 m/s stays in mode 2.
CableDyn on the mode-1 branch reproduces MoorDyn-F to 0.5 %:
The frequencies are identical.
From rest, CableDyn settles in mode 2, as MoorDyn-C v2.7.2 does. At 0.21–0.30 m/s the frequencies are identical (0.507 / 0.527 / 0.547 / 0.567 Hz). At 0.24 m/s, A/D at x/L = 0.24 is 0.575 against 0.574.
MoorDyn-F v2.3.8 (OpenFAST v5.0.0) never starts from its seed.
Line_InitializesetsLine%phi(I) = 2πI/N, but only the positions are copied into the state vectorx%states, so every phase starts at zero. The resulting uniform lift excites only the symmetric modes. MoorDyn-C copies its seed into its state.With every phase at zero, CableDyn follows MoorDyn-F's transient to four digits for 12 s, and its mode-1 branch over the whole band.
A static side note. MoorDyn-F's default
CdScaleIC 4solves its initial condition with four times the drag. On this line that raises the start tension by up to 2.8 kN. WithCdScaleIC 1its static tension equals CableDyn's to the digit.Added: OPTION
VIVphaseSeedspreadis the default: MoorDyn-C's 2πi/N.zeroreproduces MoorDyn-F's start. The Python deck validator mirrors the option.Effect on results
Tests
viv_lockingains:viv_coupledandhermite_vivcheck the new seeds.