Skip to content

perf(multibody): full Newton for cables in the monolithic step - #113

Merged
SMI-Lab-Inha merged 3 commits into
devfrom
perf/mn-multibody
Nov 8, 2026
Merged

SMI-Lab-Inha merged 3 commits into
devfrom
perf/mn-multibody

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

With modified_newton True, every finite-EI cable reused its tangent within a step. In the monolithic step of the multibody march, a cable is restored and stepped again from the same start at every coupling iteration, and there reuse cost more than it saved.

mixed_body_rods_points.dat Wall time
full Newton 5.8 s
modified_newton True, before 7.0 s
reuse off on the cables only (experiment) 5.7–6.3 s
modified_newton True, after 5.6 s

Such a cable now keeps full Newton. The other solvers in the deck keep the option.

The option's documented trade-off is re-measured on the examples, one thread:

  • Finite-EI cables: 4–20 % faster, free-hanging or with a touchdown (lazy waves in waves, current and vessel motion; a buoyed cable; rods on a spar).
  • EI = 0 cable laid on a frictional seabed in a current: 12 % slower over a 600 s march, because stick-slip friction makes the reused tangent take more iterations.
  • EI = 0 systems elsewhere: within a few per cent.

The former claim, "about 1.5 times slower on finite-EI lines on the seabed", no longer holds: the touchdown decks run 4–12 % faster with the option.

Results without the option are unchanged. Full CTest passes on Release, 365/365 on the default kernel and on Prescott.

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T13:24:13.449362Z 3e1c3c4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35732986 | 📁 Comparing 3e1c3c4 against latest (e8f88f5)

  🔍 Preview build  

5 files changed · ± 5 modified

± Modified

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29a62360e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/CableDyn_DeckDriver.f90 Resolved
With OPTIONS modified_newton True every finite-EI cable reused its tangent
within a step. A cable in the monolithic step of the multibody march is
restored and stepped again from the same start at every coupling iteration,
and there the reuse cost more than it saved: mixed_body_rods_points.dat ran
in 7.0 s with the option against 5.8 s without (5.7-6.3 s with the cables
alone kept on full Newton). Such a cable now keeps full Newton; the other
solvers of the deck keep the option. The deck runs in 5.6 s with it.

The documented trade-off of the option is measured again on the examples
(one thread): 4-20 % faster on finite-EI cables, free-hanging or with a
touchdown; 12 % slower on an EI = 0 cable laid on a frictional seabed in a
current (a 600 s march), within a few per cent elsewhere on EI = 0 systems.
The former "about 1.5 times slower on finite-EI lines on the seabed" no
longer holds: the touchdown decks run 4-12 % faster with it.

Results without the option are unchanged.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 7d89bd2fa2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: d8e361bec8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The staggered march (bodyScheme staggered) steps each cable once per step,
without the repeated coupling iterations that make tangent reuse dearer, so
a cable attached to a moving object keeps OPTIONS modified_newton there.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 3e1c3c4b65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 82cfa7a into dev Nov 8, 2026
16 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the perf/mn-multibody branch November 9, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant