Repository navigation
docs(validation): re-measure the L5 performance records and commit their scripts - #118
Conversation
…ted timing scripts The L5 performance records were measured around 0.1.0 on another host, and their models and driver scripts were not in the repository. validation/scripts/performance_records.py (with performance_models.py) now builds, checks and times every L5 case on one host, one thread, as the median of three runs after one warm-up: - L5-DPC: the matched 80/200/800 m pinned-touchdown lazy-wave spans of the L3-6 protocol. CableDyn driver decks with 240/480/960 Hermite elements, the OrcaFlex models of orcaflex_lazywave_dynamic_reference.py, and the MoorDyn-F decks of moordyn_lazywave_dynamic_reference.py refined fourfold, with an optional half-step check of the MoorDyn-F step. - L5-V: the one-hour VolturnUS-S chain, as a CableDyn deck with the l3_longduration_mooring drive and the OrcaFlex model of orcaflex_longduration_mooring.py (now exposing build_model()). - L5-wc: the WD0050 chain under the L2-2 A1 heave, CableDyn against MoorDyn-C v2.7.2 through moordyn_c_driver.cpp. Each timed model must reproduce its reference response before it is recorded. The records keep the code versions, builds and hashes, the host and date, the ranges, the host load, the CableDyn phase split and solver counts, and the driver notes. CableDyn is timed with the release driver (IFX) and with a GNU build of dev. VALIDATION.md: the L5-V, L5-wc and L5-DPC rows and the wall-clock section carry the new figures; the Hermite solver bullet is re-measured on the committed tests it names (figures without a committed case are removed); the coupled-throughput figures are labelled with their date and host. The performance records are dated history for the release-version check. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e3a069c18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The documentation build resolves VALIDATION.md links as cross-references; a relative path to a script is not one. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The write step now checks the CableDyn vs MoorDyn-C mean and maximum fairlead tension differences against WC_TOLERANCE (15 %) and refuses to write any record file when either is outside it, or when the traces share no output time. The committed records are unchanged (1.35 % and 1.71 %). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f48977fb7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
performance_records.py turned --moordyn-f-driver (default moordyn_driver), CD_MDF_DRIVER, --cabledyn-driver and --gxx into paths under the working directory, so a driver installed on PATH was never found. A name without a directory separator that is not a file there is now resolved with shutil.which, and a missing one is refused by name. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The L5 performance records in VALIDATION.md and
validation/performance/dated from about 0.1.0 and were measured on another host. Their timing models and scripts were never committed. This PR re-measures them and commits the scripts that produce them.Protocol
OMP_NUM_THREADSandOPENBLAS_NUM_THREADSare 1, and OrcaFlex runs withthreadCount = 1.Results
L5-DPC: 60 s on the pinned-touchdown lazy-wave spans
The models match OrcaFlex's hang-off tension statistics to 0.12 % for CableDyn and 0.29 % for MoorDyn-F.
L5-V: VolturnUS-S chain, one hour
The old record said 18–32 s for CableDyn against 14.5 s for OrcaFlex. The response matches L3-7.
L5-wc: 80 s on the WD0050 chain
The original external solver appears to have been MoorDyn-C v2.6.1, with deck settings that were never recorded. These rows use v2.7.2 with a documented deck, and the docs say so.
Scripts
validation/scripts/performance_records.py:runbuilds, checks and times each case;--step-checkre-checks the MoorDyn-F step;writeproduces the record files.validation/scripts/performance_models.py: writes the CableDyn, MoorDyn-C and MoorDyn-F models.orcaflex_longduration_mooring.py: now exposesbuild_model().Records
performance_summary.csv, the newwallclock_summary.csv,performance_metrics.json(versions, builds, hashes, host, responses, step checks),README.mdandPERFORMANCE_AUDIT.md.Tests
test_validation_records.pynow checks the new row structure, the JSON consistency and the MoorDyn-F step checks.release/check_release_metadata.pytreatsvalidation/performance/as dated history.No solver code changes.