Repository navigation
fix(statics): a compression on unresolved elements names the mesh, not the current - #121
Merged
Merged
Conversation
…t the current The diagnosis of a finite-EI line that stops in a current read the element-mean axial force of the last state and named a compression there as a limit of the current: the friction holding the grounded run, or the run pushed along the seabed. On an element longer than half its bending length (EI/|w|)^(1/3) the element-mean axial force of a stiff line oscillates and can read a compression the line does not carry. The deck driver then skipped the mesh-sequenced route on that diagnosis, and the solver could stop its continuation at a grounded-run limit the mesh made up. A compression on such an element (or its neighbours) now names the mesh and how to refine it, and sets no grounded-run limit, so the other routes run. driver_graded_cross_current: a lazy wave on a graded mesh (0.9 m elements beside 4 m and 10 m ones) in a 0.2 m/s cross current exits 2 before and now solves with no fallback. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: 🔄 RunningThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the static solve of a finite-EI line stops in a current, a diagnosis reads the element-mean axial force of the last state. A compression there was reported as a limit of the current: "the friction holds the grounded run" or "the run on the seabed is pushed into its end". The deck driver then skipped the mesh-sequenced route on that text, and the continuation could stop at the reported limit.
Why that was wrong
On an element longer than half its bending length (EI/|w|)^(1/3), the element-mean axial force of a stiff line oscillates and can read a compression the line does not carry. That is the same artefact the still-water diagnosis now handles in the graded-mesh fix.
Fix
current_compression_notenow takes the elements' EI and w. If the compressed element or one of its neighbours is longer than half its bending length:On a resolving mesh the diagnosis is unchanged.
Evidence
driver_graded_cross_current: a lazy wave on a graded mesh (0.9 m elements beside 4 m and 10 m ones) in a 0.2 m/s cross current. It exits 2 on dev and now solves with no fallback.cable_statics_matrix. Its current-compression decks are resolved, so their expected diagnoses are unchanged.The CHANGELOG entry goes into the batch CHANGELOG PR.