Skip to content

fix(statics): a compression on unresolved elements names the mesh, not the current - #121

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
fix/compression-note-resolution
Nov 8, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
fix/compression-note-resolution

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

When the static solve of a finite-EI line stops in a current, a diagnosis reads the element-mean axial force of the last state. A compression there was reported as a limit of the current: "the friction holds the grounded run" or "the run on the seabed is pushed into its end". The deck driver then skipped the mesh-sequenced route on that text, and the continuation could stop at the reported limit.

Why that was wrong

On an element longer than half its bending length (EI/|w|)^(1/3), the element-mean axial force of a stiff line oscillates and can read a compression the line does not carry. That is the same artefact the still-water diagnosis now handles in the graded-mesh fix.

Fix

current_compression_note now takes the elements' EI and w. If the compressed element or one of its neighbours is longer than half its bending length:

  • the note names the mesh and how to refine it;
  • it sets no grounded-run limit;
  • the skip rule no longer fires, so the other routes run.

On a resolving mesh the diagnosis is unchanged.

Evidence

  • New driver_graded_cross_current: a lazy wave on a graded mesh (0.9 m elements beside 4 m and 10 m ones) in a 0.2 m/s cross current. It exits 2 on dev and now solves with no fallback.
  • Release CTest: 368/368, no warnings.
  • Static, attachment and current tests: 37/37 on the default and Prescott kernels, including cable_statics_matrix. Its current-compression decks are resolved, so their expected diagnoses are unchanged.

The CHANGELOG entry goes into the batch CHANGELOG PR.

…t the current

The diagnosis of a finite-EI line that stops in a current read the
element-mean axial force of the last state and named a compression there as a
limit of the current: the friction holding the grounded run, or the run pushed
along the seabed. On an element longer than half its bending length
(EI/|w|)^(1/3) the element-mean axial force of a stiff line oscillates and can
read a compression the line does not carry. The deck driver then skipped the
mesh-sequenced route on that diagnosis, and the solver could stop its
continuation at a grounded-run limit the mesh made up.

A compression on such an element (or its neighbours) now names the mesh and
how to refine it, and sets no grounded-run limit, so the other routes run.
driver_graded_cross_current: a lazy wave on a graded mesh (0.9 m elements
beside 4 m and 10 m ones) in a 0.2 m/s cross current exits 2 before and now
solves with no fallback.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: 🔄 Running

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-11-08T14:09:06.316816Z 7f94a15 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35733669 | 📁 Comparing 7f94a15 against latest (e8f88f5)

  🔍 Preview build  

6 files changed · ± 6 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 7f94a15fbe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 61e591c into dev Nov 8, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/compression-note-resolution branch November 9, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant