Repository navigation
fix(statics): an EI = 0 residual cycling inside its round-off floor is converged - #122
Merged
Merged
Conversation
The EI = 0 static Newton solve converges a residual that is inside the round-off floor of its nodal forces but above the relative tolerance only when the residual stays flat over the stall window. Inside the floor the iterates can also alternate between two values (the rounding of the last digits), which the flat test never sees: the Levenberg-Marquardt stages then ran out of iterations and the line had no admissible equilibrium. Whether a deck solved depended on the last digits of its coordinates: 13 of 32 small translations of a suspended three-section line in a 0.67 m/s current failed (the residual alternating between 9.49e-5 and 8.77e-5 N, with a floor of 3.1e-3 N and a tolerance of 2.6e-5 N), and translated copies of point systems failed in their line solves. A residual inside the floor that sets no new minimum over the stall window is now converged as a flat one is. Every example deck gives the same output as before. The new ei0_static_floor_cycle test solves the 32 translated decks and requires the same end tensions from each to 1e-7. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A suspended composite EI = 0 line in a current reported "no admissible static equilibrium" depending only on the last digits of its coordinates. The base deck solved, but 13 of 32 small translations of it failed. Translated point systems failed the same way.
Cause
CableDyn_Static.f90accepted a residual inside its round-off floor only while the residual stayed flat. Here the iterates alternate between 9.49e-5 and 8.77e-5 N, against a floor of 3.1e-3 and a tolerance of 2.6e-5. Every stage therefore ran its whole iteration budget (1268 iterations) and failed.Fix
A residual inside the floor that sets no new minimum over the stall window now counts as converged.
Evidence
ei0_static_floor_cycle: the 32 translations. Before the fix 13 fail, on every OpenBLAS kernel. After it none fail, and the tensions are identical.The CHANGELOG entry goes into the batch CHANGELOG PR.