Repository navigation
fix(hermite): the axial damping in the round-off floor of the dynamic residual - #123
Merged
Merged
Conversation
The force scale of a finite-EI dynamic step is bounded below by the round-off floor of the axial forces, 16 eps max(EA/L0) x_ref/tol. The axial damping force BA d|r'|/dt takes its strain rate from the Newmark velocity, whose rounding is gamma/(beta dt) times that of the coordinates, and the floor left it out. A held line damped near its first axial mode (BA = 2 zeta EA/omega_1, as mode1 axialDampingRatio gives, or a direct BA of that size) puts the damping term well above EA at a small dtM: its steps at rest stalled at a few times the tolerance and the run stopped (3 of 30 runs of a 400 m wire held at rest over BA 5e7 to 8e8 N s and dtM 0.002 to 0.01 s, at varying points of the sweep as the rounding falls). The floor now adds BA gamma/(beta dt) to the axial stiffness of each element, as the twist floor adds the torsional damping. Lines without axial damping take the same scale as before. The new hermite_damped_rest test runs the sweep and requires every run to complete with its end tensions at their static values to 1e-6. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A finite-EI line held at rest failed its dynamic step with
Newton did not converge, ||G||=3.9e-8 > tol=1e-8whenever its axial damping was large: a BA of the order of 1e8 N·s at a small dtM, asaxialDampingRatio mode1gives a stiff line.Cause
eval_resinCableDyn_HermiteCableDynamic.f90builds a round-off floor from a force scale. That scale counted only EA/L0. The damping term BA·γ/(β dt) multiplies the rounding of the coordinates too, and it was left out. The twist floor already counts its own damping.Fix
The axial floor now adds BA·γ/(β dt), element by element. Lines without axial damping are unchanged.
Evidence
hermite_damped_rest: sweeps BA over 5e7–8e8 N·s and dtM over 0.002–0.01 s. Before the fix, 3 of 30 runs fail on the default kernel and 2 of 30 on Prescott; after it, none.mixed_body_rods_pointschanges in the last digit (8.7e-8 relative).The CHANGELOG entry goes into the batch CHANGELOG PR.