Skip to content

fix(hermite): the axial damping in the round-off floor of the dynamic residual - #123

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/damping-roundoff-floor
Nov 8, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/damping-roundoff-floor

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

A finite-EI line held at rest failed its dynamic step with Newton did not converge, ||G||=3.9e-8 > tol=1e-8 whenever its axial damping was large: a BA of the order of 1e8 N·s at a small dtM, as axialDampingRatio mode1 gives a stiff line.

Cause

eval_res in CableDyn_HermiteCableDynamic.f90 builds a round-off floor from a force scale. That scale counted only EA/L0. The damping term BA·γ/(β dt) multiplies the rounding of the coordinates too, and it was left out. The twist floor already counts its own damping.

Fix

The axial floor now adds BA·γ/(β dt), element by element. Lines without axial damping are unchanged.

Evidence

  • New hermite_damped_rest: sweeps BA over 5e7–8e8 N·s and dtM over 0.002–0.01 s. Before the fix, 3 of 30 runs fail on the default kernel and 2 of 30 on Prescott; after it, none.
  • Suites: CTest 369/369 on both kernels; pytest passes.
  • Examples: 53 of 54 are bit-identical. mixed_body_rods_points changes in the last digit (8.7e-8 relative).

The CHANGELOG entry goes into the batch CHANGELOG PR.

The force scale of a finite-EI dynamic step is bounded below by the round-off
floor of the axial forces, 16 eps max(EA/L0) x_ref/tol. The axial damping
force BA d|r'|/dt takes its strain rate from the Newmark velocity, whose
rounding is gamma/(beta dt) times that of the coordinates, and the floor left
it out. A held line damped near its first axial mode (BA = 2 zeta EA/omega_1,
as mode1 axialDampingRatio gives, or a direct BA of that size) puts the
damping term well above EA at a small dtM: its steps at rest stalled at a few
times the tolerance and the run stopped (3 of 30 runs of a 400 m wire held at
rest over BA 5e7 to 8e8 N s and dtM 0.002 to 0.01 s, at varying points of the
sweep as the rounding falls).

The floor now adds BA gamma/(beta dt) to the axial stiffness of each element,
as the twist floor adds the torsional damping. Lines without axial damping
take the same scale as before.

The new hermite_damped_rest test runs the sweep and requires every run to
complete with its end tensions at their static values to 1e-6.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T15:15:13.505897Z 33d9c9b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35735028 | 📁 Comparing 33d9c9b against latest (e8f88f5)

  🔍 Preview build  

6 files changed · ± 6 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 33d9c9bbfb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 451a4ad into dev Nov 8, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/damping-roundoff-floor branch November 9, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant