Repository navigation
fix(statics): the attachment polish accepts the line's residual floor - #124
Merged
Merged
Conversation
The finite-EI static solve of a line accepts a residual floor above the tight static tolerance at the coupled static tolerance 1e-6 and notes it. The discrete-attachment polish that follows it solved every load step at the tight tolerance only: a solve that stalled at a few times 1e-8 (a fine or locally refined mesh, a long line) went on to the pseudo-transient and merit fallbacks, which stall on the same floor, and the load steps were halved down to 1/1024 until the static start failed. A suspended cable clamped at its anchor in a tight bend with one clump failed for every clump mass and arc position tried, the polish stalling at 3e-8 to 6e-8 where the smeared equilibrium had been accepted at 2.9e-7. A polish solve whose Newton iteration stalls above the tight tolerance is now repeated from the same state at the coupled static tolerance before the next update rule, as the line's own solve is, and the run notes the residual of the discrete equilibrium when it lies above the tight tolerance. Solves that meet the tight tolerance are unchanged, and a coupled run, whose static tolerance is already 1e-6, takes the same solves as before. The new attachment_polish_floor test runs the clamped cable with a 400 or 1600 kg clump at 450 or 760 m and requires each run to converge without a fallback note, its end forces balancing the line and clump weights to 1e-5. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A finite-EI line with discrete ATTACHMENTS failed its static solve with "
||R||=5e-8 > tol=1e-8; homotopy stopped" in 12 decks of the robustness campaign. In one of them the polish failed at a residual seven times lower than the 2.9e-7 at which the smeared start had already been accepted.Cause
The line's own static solve accepts a residual floor at the coupled tolerance of 1e-6. The attachment polish solved every load step only at the tight tolerance, and its fallbacks stall on the same floor. Its load steps therefore halved until the run failed.
Fix
When a polish solve stalls, it is retried from the same state at the coupled tolerance before the fallbacks run. The run then prints a note giving the residual reached. Solves that meet the tight tolerance, and coupled runs, are unchanged.
Evidence
attachment_polish_floor: a cable clamped in a tight bend at its anchor, carrying one clump, over a grid of mass and arc position. Before the fix all 9 grid points fail. After it they converge with the floor note and balance the weights to 1e-5.The CHANGELOG entry goes into the batch CHANGELOG PR.