Skip to content

fix(python): refuse a channel token containing a NUL - #126

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/channel-token-nul
Nov 8, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/channel-token-nul

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

CableDyn.channel("FairTen1\0x") silently returned FairTen1, because the library stops reading a token at its first NUL. The binding now refuses a token that contains a NUL with a ValueError, as it already does for deck paths.

Tests. 3 cases in test_objects.py; all 3 failed before the fix. CTest 368/368 on both kernels; pytest passes.

CableDyn_EvalChannel reads a token up to its first NUL, so CableDyn.channel
passed "FairTen1\0x" through and returned FairTen1, and a token starting
with a NUL came back as a library error about an empty token. The binding now
refuses a token holding a NUL with a ValueError before calling the library,
as it already does for a deck path.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T15:31:26.241860Z 9e1a7bf Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 9e1a7bf688

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35735215 | 📁 Comparing 9e1a7bf against latest (e8f88f5)

  🔍 Preview build  

6 files changed · ± 6 modified

± Modified

@SMI-Lab-Inha
SMI-Lab-Inha merged commit ecde21a into dev Nov 8, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/channel-token-nul branch November 9, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant