Skip to content

fix(modal): note a mode with omega^2 < 0 and document its signed frequency - #132

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/modal-negative-note
Nov 8, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/modal-negative-note

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

A mode with omega² < 0 means the static state is unstable in that mode. .modes.out already writes such a mode with a signed frequency, but nothing documented that and the run said nothing.

  • outputs.rst and theory.rst now document the convention: frequency −sqrt(|omega²|)/(2π) and a period of 0.
  • The driver prints a note: "line N: K of its modes have omega^2 < 0, so its static state is unstable in them; …".

Test. modal_negative_note: an unstable 27-element cable prints the note, and a stable 108-element version of it does not. CTest passes on both BLAS kernels. Examples are unchanged.

…uency

A modal analysis about an unstable static state (a planar equilibrium unstable
out of its plane on a coarse mesh, a compressed strut) finds eigenvalues
omega^2 < 0. modes.out wrote them as a negative frequency and omega with a
period of 0, a convention neither the run nor the manual stated.

The run now prints a note naming the line and the number of such modes, and
the Outputs page and the theory manual document the signed values (Omega =
-sqrt(|omega^2|), Frequency = Omega/2 pi, Period 0).

The new modal_negative_note test runs a 27-element cable whose planar state
is unstable out of its plane (one negative mode, noted) and the same cable on
108 elements (all frequencies positive, no note).

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T16:55:07.279952Z c42b271 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: c42b271e72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35736221 | 📁 Comparing c42b271 against latest (e8f88f5)

  🔍 Preview build  

9 files changed · ± 9 modified

± Modified

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 9c79ae4 into dev Nov 8, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/modal-negative-note branch November 9, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant