Repository navigation
fix(modal): note a mode with omega^2 < 0 and document its signed frequency - #132
Merged
Merged
Conversation
…uency A modal analysis about an unstable static state (a planar equilibrium unstable out of its plane on a coarse mesh, a compressed strut) finds eigenvalues omega^2 < 0. modes.out wrote them as a negative frequency and omega with a period of 0, a convention neither the run nor the manual stated. The run now prints a note naming the line and the number of such modes, and the Outputs page and the theory manual document the signed values (Omega = -sqrt(|omega^2|), Frequency = Omega/2 pi, Period 0). The new modal_negative_note test runs a 27-element cable whose planar state is unstable out of its plane (one negative mode, noted) and the same cable on 108 elements (all frequencies positive, no note). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mode with omega² < 0 means the static state is unstable in that mode.
.modes.outalready writes such a mode with a signed frequency, but nothing documented that and the run said nothing.outputs.rstandtheory.rstnow document the convention: frequency −sqrt(|omega²|)/(2π) and a period of 0.Test.
modal_negative_note: an unstable 27-element cable prints the note, and a stable 108-element version of it does not. CTest passes on both BLAS kernels. Examples are unchanged.