Skip to content

fix(statics): the residual-floor note only for a residual above the tolerance - #133

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/static-floor-note
Nov 9, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/static-floor-note

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

The residual-floor note of the static solve took its flag from a solve repeated at a looser tolerance, but its residual from the final stage. That final stage can still land below the tight tolerance, and the note then reported a floor that was not there (a torsion deck from the fuzz campaign, torsion_30076). The note is now printed only when the final residual is above the tight tolerance.

Test. static_floor_note. CTest passes on both BLAS kernels. Examples are unchanged.

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T22:28:30.486998Z b47ae7c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35740493 | 📁 Comparing b47ae7c against latest (e8f88f5)

  🔍 Preview build  

10 files changed · ± 10 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: eebf3a09f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/static-floor-note branch from eebf3a0 to 28e2bd4 Compare November 8, 2026 17:11
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 28e2bd4d35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/static-floor-note branch from 28e2bd4 to a3436ae Compare November 8, 2026 20:06
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: a3436aea2f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…olerance

The finite-EI static solve repeats a polish that does not converge at the
tight static tolerance at the coupled tolerance 1e-6 and notes "static residual
floor above the dynamic tolerance ...; equilibrium accepted at the relative
residual ...". The repeated polish can end below the tight tolerance (its last
Newton step lands there), and the note then reported a residual below the
tolerance it said was missed: "1.00E-08; ... accepted at ... 6.91E-09" for a
two-section line restrained in torsion.

The note is now printed only when the residual reached lies above the tight
tolerance. The solves and their results are unchanged.

The new static_floor_note test runs that line and requires every such note to
report a residual above its tolerance.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/static-floor-note branch from a3436ae to b47ae7c Compare November 8, 2026 22:27
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: b47ae7c85b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 177e19e into dev Nov 9, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/static-floor-note branch November 9, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant