Repository navigation
fix(statics): the residual-floor note only for a residual above the tolerance - #133
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
eebf3a0 to
28e2bd4
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
28e2bd4 to
a3436ae
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…olerance The finite-EI static solve repeats a polish that does not converge at the tight static tolerance at the coupled tolerance 1e-6 and notes "static residual floor above the dynamic tolerance ...; equilibrium accepted at the relative residual ...". The repeated polish can end below the tight tolerance (its last Newton step lands there), and the note then reported a residual below the tolerance it said was missed: "1.00E-08; ... accepted at ... 6.91E-09" for a two-section line restrained in torsion. The note is now printed only when the residual reached lies above the tight tolerance. The solves and their results are unchanged. The new static_floor_note test runs that line and requires every such note to report a residual above its tolerance. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
a3436ae to
b47ae7c
Compare
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The residual-floor note of the static solve took its flag from a solve repeated at a looser tolerance, but its residual from the final stage. That final stage can still land below the tight tolerance, and the note then reported a floor that was not there (a torsion deck from the fuzz campaign, torsion_30076). The note is now printed only when the final residual is above the tight tolerance.
Test.
static_floor_note. CTest passes on both BLAS kernels. Examples are unchanged.