Repository navigation
fix(statics): note a Point3 buoy that starts off balance - #134
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The static solve does not place a Point3 buoy: it starts at its deck position (theory.rst). Under the default bodyIC static every other free object starts balanced, so a buoy given off its balance started there without a word: a 112 t, 259 m^3 buoy on one slack leg started with 1.5 MN of net buoyancy unbalanced and surfaced within 2 s. Under bodyIC static the point initial condition now evaluates the buoy as a Free point (the core static solve with the Free/Connect points held where it put them) and, when the net force on it at its deck position exceeds 1e-4 of its net weight plus 1 N, notes that force and the distance to its static balance, with the remedies (its balanced deck position, or bodyIC deck). The solve and the march are unchanged; bodyIC deck prints nothing. The core solve returns the starting net force of each moving point for it (point_force_start). The new point3_balance_note test runs the buoy under bodyIC static (the noted force must equal the line force on it plus its net buoyancy to 1e-3) and under bodyIC deck (no note). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
61ea9cd to
6f21fab
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The static solve does not place a Point3 buoy (
theory.rst): the buoy starts at its deck position. UnderbodyIC staticevery other free object starts in balance, so a buoy that is far out of balance was easy to miss.The driver now solves a quiet, points-only balance for the buoy, with the Free and Connect points held where the static solve put them. When the buoy's unbalanced force at its deck position exceeds 1e-4·|ρV − M|g + 1 N, a note gives that force and the distance to the buoy's equilibrium, and suggests giving the equilibrium position or
bodyIC deck. Behaviour is unchanged;driver_format.mdandtheory.rstdescribe the note.Test.
point3_balance_note. CTest passes on both BLAS kernels. Examples are unchanged.