Skip to content

fix(statics): note a Point3 buoy that starts off balance - #134

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/point3-balance-note
Nov 8, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/point3-balance-note

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

The static solve does not place a Point3 buoy (theory.rst): the buoy starts at its deck position. Under bodyIC static every other free object starts in balance, so a buoy that is far out of balance was easy to miss.

The driver now solves a quiet, points-only balance for the buoy, with the Free and Connect points held where the static solve put them. When the buoy's unbalanced force at its deck position exceeds 1e-4·|ρV − M|g + 1 N, a note gives that force and the distance to the buoy's equilibrium, and suggests giving the equilibrium position or bodyIC deck. Behaviour is unchanged; driver_format.md and theory.rst describe the note.

Test. point3_balance_note. CTest passes on both BLAS kernels. Examples are unchanged.

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T17:12:58.683855Z 6f21fab Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35736514 | 📁 Comparing 6f21fab against latest (e8f88f5)

  🔍 Preview build  

10 files changed · ± 10 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 61ea9cdd1c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The static solve does not place a Point3 buoy: it starts at its deck position
(theory.rst). Under the default bodyIC static every other free object starts
balanced, so a buoy given off its balance started there without a word: a
112 t, 259 m^3 buoy on one slack leg started with 1.5 MN of net buoyancy
unbalanced and surfaced within 2 s.

Under bodyIC static the point initial condition now evaluates the buoy as a
Free point (the core static solve with the Free/Connect points held where it
put them) and, when the net force on it at its deck position exceeds 1e-4 of
its net weight plus 1 N, notes that force and the distance to its static
balance, with the remedies (its balanced deck position, or bodyIC deck). The
solve and the march are unchanged; bodyIC deck prints nothing. The core solve
returns the starting net force of each moving point for it
(point_force_start).

The new point3_balance_note test runs the buoy under bodyIC static (the noted
force must equal the line force on it plus its net buoyancy to 1e-3) and under
bodyIC deck (no note).

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/point3-balance-note branch from 61ea9cd to 6f21fab Compare November 8, 2026 17:11
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 6f21fabf67

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit ec86473 into dev Nov 8, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/point3-balance-note branch November 9, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant